Update config sections and add a configuration tool. #2442
+2,608
−1,388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add token checking to configure.py
Add options to lang.py -L for language select. Add experimental lang.py option -A for machine translation via argostranslate local downloaded models.
… describe the missing options. Fix display of values in the config show command.
Add cli option to update example files. Permissions extractor list is now sorted.
itsTheFae
force-pushed
the
config-cli-tool
branch
from
8d8b52a to
cb5f531
Compare
Fix bug with previous attachment logic.
Mark some more strings as translatable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch (the latest developmental version), and this pull request is targeting that branch as a baseDescription
Draft for discussion and review of non-backward compatible changes to
options.iniThis PR re-organizes options.ini with new sections for better clarity. It also adds a configuration tool which can be used to manage all of the configuration of MusicBot, with exception of playlist management functions.
Naturally, the install scripts have been updated to make use of the new configure.py tool in place of the previous configuration logic available in each install script.
The
configure.pyis intended to be run directly via python. It requireswindows-cursespip package on windows, and will attempt to automatically install this package if it is missing.This tool will check the Token option when it is updated to make sure it is working but it will not prevent the user from saving an invalid token the same way it may prevent updating some options with invalid values.
Noteworthy changes
This replaces the previous config steps in install scripts and can be used stand-alone at any time.
playcommands to also play attachments, instead of manually copying the attachment link.searchcommand.DefaultSearchServiceprefix in options.inilang.pynow includes calling function/keyword in POT files.lang.pynow offer language selection and Machine translation via argostranslate.config missingproducing more text than discord will allow to send.UseOpusAudioas enabled by default. (seems better than PCM in most cases.)TODO