Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR review changes #166

Merged
merged 4 commits into from
Oct 27, 2024
Merged

PR review changes #166

merged 4 commits into from
Oct 27, 2024

Conversation

lkdvos
Copy link
Collaborator

@lkdvos lkdvos commented Oct 26, 2024

Added some minor changes I found while browsing through the PR:

  • Updated the changelog
  • Re-enabled formatting the TensorMap struct definition
  • Changed a docstring to reflect that the fully typed TensorMap{E,S,N1,N2,A} requires homspaces, not two productspace arguments

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.56%. Comparing base (e48e672) to head (3afacbb).
Report is 4 commits behind head on jh/tensorstructure.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           jh/tensorstructure     #166   +/-   ##
===================================================
  Coverage               79.56%   79.56%           
===================================================
  Files                      41       41           
  Lines                    4908     4908           
===================================================
  Hits                     3905     3905           
  Misses                   1003     1003           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jutho Jutho merged commit b3aabea into jh/tensorstructure Oct 27, 2024
14 checks passed
@lkdvos lkdvos deleted the ld-tensorstructure branch October 27, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants