Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore randisometry, add tests and deprecations #170

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Conversation

Jutho
Copy link
Owner

@Jutho Jutho commented Nov 1, 2024

No description provided.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 56.66667% with 13 lines in your changes missing coverage. Please review.

Project coverage is 81.19%. Comparing base (a012324) to head (d95dfd0).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/tensors/tensor.jl 57.14% 9 Missing ⚠️
src/auxiliary/random.jl 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
+ Coverage   81.15%   81.19%   +0.03%     
==========================================
  Files          41       41              
  Lines        4999     5003       +4     
==========================================
+ Hits         4057     4062       +5     
+ Misses        942      941       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! I suggested some slight additions to the docstrings to improve discoverability, but otherwise good to go.

src/tensors/tensor.jl Outdated Show resolved Hide resolved
src/tensors/tensor.jl Show resolved Hide resolved
Co-authored-by: Lukas Devos <[email protected]>
@Jutho Jutho merged commit 30fb498 into master Nov 3, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants