cmake: Fix release build

KDABLabs · Jan 19, 2025 · 91c2660 · 91c2660
1 parent df5684e
commit 91c2660
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/CMakePresets.json b/CMakePresets.json
@@ -1,19 +1,26 @@
 {
   "version": 3,
   "configurePresets": [
+    {
+      "name": "base",
+      "environment": {
+        "CXX": "clang++",
+        "CC": "clang"
+      },
+      "cacheVariables": {
+        "CMAKE_EXPORT_COMPILE_COMMANDS": "ON"
+      },
+      "generator": "Ninja"
+    },
     {
       "name": "dev",
+      "inherits": "base",
       "description": "dev",
       "generator": "Ninja",
       "binaryDir": "${sourceDir}/build-dev",
       "cacheVariables": {
         "CMAKE_BUILD_TYPE": "Debug",
-        "CMAKE_EXPORT_COMPILE_COMMANDS": "ON",
         "DEVELOPER_BUILD": "ON"
-      },
-      "environment": {
-        "CXX": "clang++",
-        "CC": "clang"
       }
     },
     {
@@ -45,12 +52,11 @@
     },
     {
       "name": "rel",
+      "inherits": "base",
       "description": "rel",
-      "generator": "Ninja",
       "binaryDir": "${sourceDir}/build-rel",
       "cacheVariables": {
         "CMAKE_BUILD_TYPE": "Release",
-        "CMAKE_EXPORT_COMPILE_COMMANDS": "ON",
         "QT_EMBEDDER_AOT": "ON"
       }
     }

diff --git a/main.cpp b/main.cpp
@@ -121,7 +121,9 @@ int main(int argc, char **argv)
         features |= Embedder::Feature::GL;
 
     Embedder embedder(features);
+#ifdef DEVELOPER_BUILD
     registerDummyMethodChannel(embedder);
+#endif
 
     const auto icuPath = std::string(FLUTTER_ICUDTL_DIR) + std::string("/icudtl.dat");