Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progressive calls #472

Merged
merged 10 commits into from
Jul 24, 2024
Merged

Progressive calls #472

merged 10 commits into from
Jul 24, 2024

Conversation

KSDaemon
Copy link
Owner

@KSDaemon KSDaemon commented Jul 14, 2024

This PR introduces new feature: progressive call invocations (don't mess with progressive call results).

So now you can not only get results in chunks, but also send payload for stored procedure in chunks.

This refs and closes #183

  • Created a progressiveCall public API function for making progressive calls
  • Fix wampy cli test mock
  • Some code improvements and refactoring
  • Fix progress flag processing during progressive call invocation
  • Add tests for progressive call invocations
  • Fix progressiveCall to be non async
  • Fix progressiveCall tests to be non async
  • Add docs about progressiveCall() API

What kind of change does this PR introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no new functionality, only code improvements)

Checklist:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • Overall test coverage is not decreased.
  • All new and existing tests passed.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@KSDaemon KSDaemon changed the title progressive calls Progressive calls Jul 14, 2024
@KSDaemon
Copy link
Owner Author

@lucasrmendonca (or anyone else) Maybe you can have a look. Having another pair of eyes on the new code will be good. Ping me if you'll have any feedback! Thnx in advance!

@KSDaemon
Copy link
Owner Author

Okay. I'll merge it as is.

@KSDaemon KSDaemon merged commit 6919624 into dev Jul 24, 2024
7 checks passed
@KSDaemon KSDaemon deleted the progressive-calls branch July 24, 2024 09:49
@lucasrmendonca
Copy link
Contributor

Hi, sorry for the late answer, I'm currently on vacation 🌴

@KSDaemon
Copy link
Owner Author

@lucasrmendonca oh great! No worries! Have a great time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progressive calls
2 participants