Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for...of return issue #782

Merged
merged 1 commit into from
Mar 8, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/gmail.js
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,7 @@
"false": !1,
"null": null
};
each(params.replace(/\+/g, " ").split("&"), function (v, j) {

Check warning on line 752 in src/gmail.js

View workflow job for this annotation

GitHub Actions / build (16.x)

'j' is defined but never used

Check warning on line 752 in src/gmail.js

View workflow job for this annotation

GitHub Actions / build (17.x)

'j' is defined but never used

Check warning on line 752 in src/gmail.js

View workflow job for this annotation

GitHub Actions / build (18.x)

'j' is defined but never used
var param = v.split("="),
key = decodeURIComponent(param[0]),
val,
Expand Down Expand Up @@ -800,7 +800,7 @@
}
};

api.tools.parse_actions = function(params, xhr) {

Check warning on line 803 in src/gmail.js

View workflow job for this annotation

GitHub Actions / build (16.x)

'xhr' is defined but never used

Check warning on line 803 in src/gmail.js

View workflow job for this annotation

GitHub Actions / build (17.x)

'xhr' is defined but never used

Check warning on line 803 in src/gmail.js

View workflow job for this annotation

GitHub Actions / build (18.x)

'xhr' is defined but never used

// upload_attachment event - if found, don"t check other observers. See issue #22
if(params.url.act === "fup" || params.url.act === "fuv" || params.body_is_object) {
Expand Down Expand Up @@ -1918,7 +1918,7 @@
}

let parsedResponse = [];
let originalResponse = response;

Check warning on line 1921 in src/gmail.js

View workflow job for this annotation

GitHub Actions / build (16.x)

'originalResponse' is assigned a value but never used

Check warning on line 1921 in src/gmail.js

View workflow job for this annotation

GitHub Actions / build (17.x)

'originalResponse' is assigned a value but never used

Check warning on line 1921 in src/gmail.js

View workflow job for this annotation

GitHub Actions / build (18.x)

'originalResponse' is assigned a value but never used
try {
// gmail post response structure
// )}]"\n<datalength><rawData>\n<dataLength><rawData>...
Expand Down Expand Up @@ -2097,7 +2097,7 @@
const win = api.helper.get_xhr_window();

api.tools.patch(win.XMLHttpRequest.prototype.open, (orig) => {
win.XMLHttpRequest.prototype.open = function (method, url, async, user, password) {

Check warning on line 2100 in src/gmail.js

View workflow job for this annotation

GitHub Actions / build (16.x)

'async' is defined but never used

Check warning on line 2100 in src/gmail.js

View workflow job for this annotation

GitHub Actions / build (16.x)

'user' is defined but never used

Check warning on line 2100 in src/gmail.js

View workflow job for this annotation

GitHub Actions / build (16.x)

'password' is defined but never used

Check warning on line 2100 in src/gmail.js

View workflow job for this annotation

GitHub Actions / build (17.x)

'async' is defined but never used

Check warning on line 2100 in src/gmail.js

View workflow job for this annotation

GitHub Actions / build (17.x)

'user' is defined but never used

Check warning on line 2100 in src/gmail.js

View workflow job for this annotation

GitHub Actions / build (17.x)

'password' is defined but never used

Check warning on line 2100 in src/gmail.js

View workflow job for this annotation

GitHub Actions / build (18.x)

'async' is defined but never used

Check warning on line 2100 in src/gmail.js

View workflow job for this annotation

GitHub Actions / build (18.x)

'user' is defined but never used

Check warning on line 2100 in src/gmail.js

View workflow job for this annotation

GitHub Actions / build (18.x)

'password' is defined but never used
var out = orig.apply(this, arguments);
this.xhrParams = {
method: method.toString(),
Expand Down Expand Up @@ -2389,7 +2389,7 @@
// loop through applicable types
var types = type ? [ type ] : [ "before", "on", "after", "dom" ];
for (let type of types) {
if(typeof api.tracker.watchdog[type] !== "object") return true; // no callbacks for this type
if(typeof api.tracker.watchdog[type] !== "object") continue; // no callbacks for this type

// if action specified, remove any callbacks for this action, otherwise remove all callbacks for all actions
if(action) {
Expand Down Expand Up @@ -2756,7 +2756,7 @@

// observes every element inserted into the DOM by Gmail and looks at the classes on those elements,
// checking for any configured observers related to those classes
api.tools.insertion_observer = function(target, dom_observers, dom_observer_map, sub) {

Check warning on line 2759 in src/gmail.js

View workflow job for this annotation

GitHub Actions / build (16.x)

'sub' is defined but never used

Check warning on line 2759 in src/gmail.js

View workflow job for this annotation

GitHub Actions / build (17.x)

'sub' is defined but never used

Check warning on line 2759 in src/gmail.js

View workflow job for this annotation

GitHub Actions / build (18.x)

'sub' is defined but never used
//console.log("insertion", target, target.className);
if(!dom_observer_map) return;

Expand All @@ -2767,7 +2767,7 @@
for (let className of classes) {
var observers = dom_observer_map[className];
if (!observers) {
return;
continue;
}

for (var observer of observers) {
Expand All @@ -2779,7 +2779,7 @@

// if a config id specified for this observer, ensure it matches for this element
if(config.selector && !element.is(config.selector)) {
return;
break;
}

// check for any defined sub_selector match - if not found, then this is not a match for this observer
Expand Down
Loading