Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windy weather detection #915

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix windy weather detection #915

wants to merge 1 commit into from

Conversation

Mygod
Copy link

@Mygod Mygod commented Jan 17, 2025

Description

Windy detection not implemented.

Motivation and Context

See code for source.

How Has This Been Tested?

lolz

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jfberry
Copy link
Collaborator

jfberry commented Jan 17, 2025

Thank you for this!
I don't know what they are - but conditions 30 and 31 are now missing from your selection list. Was this intentional?

@Mygod
Copy link
Author

Mygod commented Jan 17, 2025

From my testing those weather icons are only used in daily forecasts but not hourly. See https://docs.google.com/spreadsheets/d/1v51qbI1egh6eBTk-NTaRy3Qlx2Y2v9kDYqmvHlmntJE/edit

EDIT: Furthermore, those also do not seem to map to a unique in-game weather.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants