Remove linking against unused legacy OpenGL GLX implementation. #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it looks like this dependency was inherited from f3d i did a full search for GLX in the SoH codebase and i did not see it being used anywhere soh testing PR HarbourMasters/Shipwright#3892 |
briaguya-ai
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
the appimage from HarbourMasters/Shipwright#3892 is working for me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, f3d used GLX-specific code for context initialization.
LUS has moved away from that, and expects SDL to be used for abstraction (we aren't doing any X specific stuff that would require us to include GLX).
Based on this (and local tests on GNU/Linux systems with Xorg/Wayland and KMS/DRM only) it's safe to simply remove
${OPENGL_glx_LIBRARY}from that line.