Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove linking against unused GLEW on GNU/Linux. #420

Merged
merged 10 commits into from
Feb 8, 2024
Merged

Remove linking against unused GLEW on GNU/Linux. #420

merged 10 commits into from
Feb 8, 2024

Conversation

vanfanel
Copy link
Contributor

@vanfanel vanfanel commented Feb 1, 2024

GLEW does not seem to be used on GNU/Linux at all, so linking against it seems unnecessary: not linking against it has zero consequences, the engine builds and works without problems.

Not depending on GLEW makes SOH/LUS more easily portable to light GNU/Linux based desktop-less systems (building Xorg-less GLEW is possible but problematic), so this is all benefits.

@briaguya-ai
Copy link
Collaborator

what about

@vanfanel
Copy link
Contributor Author

vanfanel commented Feb 6, 2024

@briaguya-ai Yes, GLEW headers are apparently used instead of using SDL2 OpenGL headers.

We don't need to depend on GLEW just for headers that SDL2 already provides.

That's corrected in fdf95bd

@vanfanel
Copy link
Contributor Author

vanfanel commented Feb 6, 2024

@briaguya-ai Now everything builds without depending on GLEW headers.

Copy link
Collaborator

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're changing too much here. keep it linux only for now. if you want to make a follow up PR removing GLEW for all platforms go for it, but this looks like a lot of copy-pasting with zero testing

extern/CMakeLists.txt Outdated Show resolved Hide resolved
extern/CMakeLists.txt Outdated Show resolved Hide resolved
src/graphic/Fast3D/gfx_opengl.cpp Outdated Show resolved Hide resolved
@Kenix3 Kenix3 merged commit bd20dd4 into Kenix3:main Feb 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants