-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove linking against unused GLEW on GNU/Linux. #420
Conversation
what about
|
@briaguya-ai Yes, GLEW headers are apparently used instead of using SDL2 OpenGL headers. We don't need to depend on GLEW just for headers that SDL2 already provides. That's corrected in fdf95bd |
@briaguya-ai Now everything builds without depending on GLEW headers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're changing too much here. keep it linux only for now. if you want to make a follow up PR removing GLEW for all platforms go for it, but this looks like a lot of copy-pasting with zero testing
GLEW does not seem to be used on GNU/Linux at all, so linking against it seems unnecessary: not linking against it has zero consequences, the engine builds and works without problems.
Not depending on GLEW makes SOH/LUS more easily portable to light GNU/Linux based desktop-less systems (building Xorg-less GLEW is possible but problematic), so this is all benefits.