Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove detection of unused PulseAudio audio libary. #421

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Remove detection of unused PulseAudio audio libary. #421

merged 2 commits into from
Feb 6, 2024

Conversation

vanfanel
Copy link
Contributor

@vanfanel vanfanel commented Feb 2, 2024

On GNU/Linux, SDL2 audio is now used instead of PulseAudio, which abstracts the underlying audio system as intended (on GNU/Linux it can ALSA, PipeWire, PulseAudio, etc. and there's no need to access them directly since SDL2 makes a perfect job abstracting that).

PulseAudio is not used anywhere in the code, so trying to detect it is unnecessary.
This makes the PulseAudio dependency finally go away, since this detection at build time is all that remains.

@briaguya-ai
Copy link
Collaborator

i think there is more cleanup to be done here. https://github.com/search?q=repo%3AKenix3%2Flibultraship+pulse&type=code

we're already migrating anyone with pulse in their config over to sdl

// Migrate pulse player in config to sdl
if (backendName == "pulse") {
SetAudioBackend(AudioBackend::SDL);
return AudioBackend::SDL;
}

but we still have pulse as an available backend

enum class AudioBackend { WASAPI, PULSE, SDL };

#ifdef __linux
mAvailableAudioBackends->push_back(AudioBackend::PULSE);
#endif

@vanfanel
Copy link
Contributor Author

vanfanel commented Feb 3, 2024

@briaguya-ai Removed the remaining PulseAudio backend references from the code in ff4f9be

@Kenix3 Kenix3 merged commit ef0c348 into Kenix3:main Feb 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants