Fix crash on texture load with missing/empty resources #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran into a crash when the game tried to load textures from resources that were either missing or had empty data. Added quick checks to exit early in `Gui::LoadTextureFromRawImage` if the resource or its buffer is null or empty. This stops the crash and logs an error instead. Should help avoid similar issues in the future.
Kenix3
requested changes
Feb 19, 2024
src/window/gui/Gui.cpp
Outdated
| @@ -232,6 +232,11 @@ void Gui::ImGuiBackendInit() { | |||
| void Gui::LoadTextureFromRawImage(const std::string& name, const std::string& path) { | |||
| const auto res = Context::GetInstance()->GetResourceManager()->GetArchiveManager()->LoadFileRaw(path); | |||
|
|
|||
| if (!res || !res->Buffer || res->Buffer->empty()) { | |||
There was a problem hiding this comment.
Can you separate out the buffer check from the res == null check?
There was a problem hiding this comment.
Can you separate out the buffer check from the res == null check?
Yeh, no problem. Check out the latest commit.
Per Kenix's request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into a crash when the game tried to load textures from resources that were either missing or had empty data. Added quick checks to exit early in
Gui::LoadTextureFromRawImageif the resource or its buffer is null or empty. This stops the crash and logs an error instead. Per Archez, I needed to regenerate my soh.otr via the cmake target. The recent input viewer changes add some new images that use this method, but these new checks should help avoid similar issues in the future.crash log.txt