Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add control for managing framebuffer clearing #732

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

Archez
Copy link
Contributor

@Archez Archez commented Dec 3, 2024

This adds the ability to decide whether to clear color or depth data (or both) on a framebuffer.

Prior to #607 we always cleared both. After #607 we only were clearing depth data. This had a negative impact on the "main" framebuffer used for rendering imgui where artifacts were preserved. This would appear whenever the game render space was not identical to the main window (like when using advanced resolution features).

With ability to clear things independently, we can now ensure that the main framebuffer is always cleared if the game is not rendered to it. This should resolve issues with the advanced resolution editor, without reverting anything needed by #607

@Kenix3 Kenix3 merged commit 31c8000 into Kenix3:main Dec 6, 2024
5 checks passed
@Archez Archez deleted the framebuffer-clearing branch December 6, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants