Mouse mapping support

[lightmanLP]

Support for binding mouse keys

• update dxgi mouse capture to make it compatible with sdl
• fix fullscreen dxgi mouse capture behavior

co-authored-by: @lilacLunatic

[briaguya-ai]

overall stuff is looking good! left a few comments (some you already had todos for)

i wasn't able to test this out locally (now that the resourcefilter stuff landed it seems the soh side of that will need to land before testing this is straightforward), but i was hoping to test out what the mapping experience - specifically what happens when this popup is visible

and someone clicks on (or misses when trying to click on) the cancel button

[lightmanLP]

Cancel button click should work without any problems, you can test it here https://github.com/lightmanLP/2ship2harkinian/tree/mouse-mapping-test
P.S. slightly outdated because of release-version LUS

[briaguya-ai]

Cancel button click should work without any problems, you can test it here https://github.com/lightmanLP/2ship2harkinian/tree/mouse-mapping-test P.S. slightly outdated because of release-version LUS

the cancel button does seem to work as expected, but i am still somewhat concerned about always capturing mouse when reading input for mappings

accidental mouse inputs are decently common, so having some safeguards would be nice

one example i noticed when testing this out was if someone accidentally double clicks on an existing mapping it'll replace the mapping

Screencast.From.2024-12-18.10-13-50.mp4

i'd like to hear what others think about this (is it a problem we should worry about? if it's a problem we should worry about, what would a good solution be?)

[lightmanLP]

one example i noticed when testing this out was if someone accidentally double clicks on an existing mapping it'll replace the mapping

It might be fixed by spawning binding popup offsetted from cursor and checking for cursor to be in popup boundaries for mouse binding

[briaguya-ai]

It might be fixed by spawning binding popup offsetted from cursor and checking for cursor to be in popup boundaries for mouse binding

that seems reasonable to me!

it doesn't solve the "tried to click the cancel button and missed" problem but that's probably fine - if people start reporting that as a bug once this ships we can look into other solutions

[lightmanLP]

It might be fixed by spawning binding popup offsetted from cursor and checking for cursor to be in popup boundaries for mouse binding

Implemented
For testing purposes: https://github.com/lightmanLP/2ship2harkinian/actions/runs/12521779818

[lightmanLP]

Made version of 2S2H with latest LUS and mouse mapping on top
HarbourMasters/2ship2harkinian#910

[briaguya-ai]

@lightmanLP I just tested the latest build from https://github.com/lightmanLP/2ship2harkinian/actions/workflows/main.yml (387fb85) and it seems like using the mouse in the popped out input editor is completely broken (but it's working perfectly in the esc menu)

is that something you've tested/been able to repro?

[lightmanLP]

Just downloaded latest, everything seems fine for me. Can you explain what exactly happened?
Only issue with popped out editor that I bumped in always is mapping window doesn't work when it's outside the game window (and its known issue for keyboard, same for mouse).

[briaguya-ai]

after trying again i was unable to reproduce the issue

[briaguya-ai]