try sdl3 #783
Draft
try sdl3 #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 5, 2025
briaguya-ai
commented
Jan 5, 2025
| @@ -1,6 +1,8 @@ | |||
| #include "SDLAudioPlayer.h" | |||
| #include <spdlog/spdlog.h> | |||
|
|
|||
| // todo: https://wiki.libsdl.org/SDL3/README/migration#sdl_audioh | |||
Comment on lines
+65
to
+66
| // todo: SDL_GameControllerHasLED() - replaced with SDL_PROP_GAMEPAD_CAP_RGB_LED_BOOLEAN | ||
| // if (SDL_GameControllerHasLED(controller)) { |
Comment on lines
+85
to
+86
| // todo: SDL_GameControllerHasRumble() - replaced with SDL_PROP_GAMEPAD_CAP_RUMBLE_BOOLEAN | ||
| // bool hasRumble = SDL_GameControllerHasRumble(controller); |
Comment on lines
+17
to
+18
| // todo: SDL_GameControllerHasLED() - replaced with SDL_PROP_GAMEPAD_CAP_RGB_LED_BOOLEAN | ||
| // if (!SDL_GameControllerHasLED(mController)) { |
Comment on lines
+48
to
+54
| // todo: move a bunch of stuff in here over to use instance ids | ||
| // char guidString[33]; // SDL_GUID_LENGTH + 1 for null terminator | ||
| // SDL_GetJoystickGUIDForID() | ||
| // SDL_GUIDToString(SDL_JoystickGetDeviceGUID(sdlIndex), guidString, sizeof(guidString)); | ||
| // std::string sdlControllerName = SDL_GameControllerNameForIndex(sdlIndex) != nullptr | ||
| // ? SDL_GameControllerNameForIndex(sdlIndex) | ||
| // : "Game Controller"; |
Comment on lines
+255
to
+266
| /* todo: | ||
|
|
||
| SDL_WINDOW_FULLSCREEN_DESKTOP has been removed, and you can call SDL_GetWindowFullscreenMode() | ||
| to see whether an exclusive fullscreen mode will be used or the borderless fullscreen desktop mode | ||
| will be used when the window is fullscreen. | ||
|
|
||
| */ | ||
|
|
||
| if (SDL_SetWindowFullscreen(wnd, on)) { | ||
| // on ? (CVarGetInteger(CVAR_SDL_WINDOWED_FULLSCREEN, 0) ? SDL_WINDOW_FULLSCREEN_DESKTOP | ||
| // : SDL_WINDOW_FULLSCREEN) | ||
| // : 0) >= 0) { |
Comment on lines
+418
to
+427
| /* todo: | ||
|
|
||
| SDL_RENDERER_ACCELERATED - all renderers except SDL_SOFTWARE_RENDERER are accelerated | ||
| SDL_RENDERER_PRESENTVSYNC - replaced with SDL_PROP_RENDERER_CREATE_PRESENT_VSYNC_NUMBER | ||
| during renderer creation and SDL_PROP_RENDERER_VSYNC_NUMBER | ||
| after renderer creation | ||
|
|
||
| */ | ||
|
|
||
| renderer = SDL_CreateRenderer(wnd, nullptr); |
Comment on lines
+474
to
+484
| /* todo: | ||
|
|
||
| SDL_GetMouseState(), SDL_GetGlobalMouseState(), SDL_GetRelativeMouseState(), | ||
| SDL_WarpMouseInWindow(), and SDL_WarpMouseGlobal() all use floating point mouse | ||
| positions, to provide sub-pixel precision on platforms that support it. | ||
|
|
||
| */ | ||
| static float fx, fy; | ||
| SDL_GetMouseState(&fx, &fy); | ||
| *x = static_cast<int>(fx); | ||
| *y = static_cast<int>(fy); |
Comment on lines
+488
to
+498
| /* todo: | ||
|
|
||
| SDL_GetMouseState(), SDL_GetGlobalMouseState(), SDL_GetRelativeMouseState(), | ||
| SDL_WarpMouseInWindow(), and SDL_WarpMouseGlobal() all use floating point mouse | ||
| positions, to provide sub-pixel precision on platforms that support it. | ||
|
|
||
| */ | ||
| static float fx, fy; | ||
| SDL_GetRelativeMouseState(&fx, &fy); | ||
| *x = static_cast<int>(fx); | ||
| *y = static_cast<int>(fy); |
Comment on lines
+16
to
+24
| /* todo: | ||
| The callback passed to SDL_AddTimer() has changed parameters to: | ||
| Uint32 SDLCALL TimerCallback(void *userdata, SDL_TimerID timerID, Uint32 interval); | ||
| */ | ||
|
|
||
| // SDL_AddTimer(16, &__lusViCallback, NULL); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overall todo list on the soh PR
sdl migration guide https://wiki.libsdl.org/SDL3/README/migration