Skip to content

Dev leads phase1

Dev leads phase1 #5

Triggered via pull request December 14, 2023 16:17
Status Success
Total duration 1m 22s
Artifacts

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
Build and Test: src/Kentico.Xperience.CRM.Common/Configuration/CommonIntegrationSettings.cs#L10
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
Build and Test: src/Kentico.Xperience.CRM.Common/Mapping/ICRMFieldMapping.cs#L6
Rename interface 'ICRMFieldMapping' to match pascal case naming rules, consider using 'ICrmFieldMapping'. (https://rules.sonarsource.com/csharp/RSPEC-101)
Build and Test: src/Kentico.Xperience.CRM.Common/Mapping/Implementations/CRMFieldMappingFunction.cs#L10
Rename class 'CRMFieldMappingFunction' to match pascal case naming rules, consider using 'CrmFieldMappingFunction'. (https://rules.sonarsource.com/csharp/RSPEC-101)
Build and Test: src/Kentico.Xperience.CRM.Common/Mapping/Implementations/CRMFieldNameMapping.cs#L6
Rename class 'CRMFieldNameMapping' to match pascal case naming rules, consider using 'CrmFieldNameMapping'. (https://rules.sonarsource.com/csharp/RSPEC-101)
Build and Test: src/Kentico.Xperience.CRM.Common/Services/Implementations/LeadsIntegrationServiceCommon.cs#L18
Change the visibility of this constructor to 'protected'. (https://rules.sonarsource.com/csharp/RSPEC-3442)
Build and Test: src/Kentico.Xperience.CRM.Dynamics/Configuration/DynamicsBizFormsMappingConfiguration.cs#L8
Remove this empty class, write its code or make it an "interface". (https://rules.sonarsource.com/csharp/RSPEC-2094)
Build and Test: src/Kentico.Xperience.CRM.Dynamics/Services/DynamicsLeadsIntegrationService.cs#L108
Extract the assignment of 'leadEntity[m.CrmFieldName]' from this expression. (https://rules.sonarsource.com/csharp/RSPEC-1121)
Build and Test: src/Kentico.Xperience.CRM.Dynamics/Services/DynamicsLeadsIntegrationService.cs#L109
The parameter name 'CRMFieldMapping' is not declared in the argument list. (https://rules.sonarsource.com/csharp/RSPEC-3928)
Build and Test: src/Kentico.Xperience.CRM.SalesForce/Configuration/SalesForceBizFormsMappingConfiguration.cs#L8
Remove this empty class, write its code or make it an "interface". (https://rules.sonarsource.com/csharp/RSPEC-2094)
Build and Test: src/Kentico.Xperience.CRM.SalesForce/Services/SalesForceLeadsIntegrationService.cs#L103
Extract the assignment of 'lead.AdditionalProperties[m.CrmFieldName]' from this expression. (https://rules.sonarsource.com/csharp/RSPEC-1121)