Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve: GUI messages for signing algorithm in CA creation form #773

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dcarella
Copy link
Contributor

@dcarella dcarella commented Jan 15, 2025

Change description

Improve messages for signing algorithm, in CA creation form:

  • Rename "Select an algorithm to activate hybrid certificates" to "None alternative signature", and localize it
  • Refactor the message key ALTERNATIVESIGNINGALGORITHM to SIGNINGALGORITHM_ALTERNATIVE, and move it (better for localizators ;-))
  • Fix some messages (English, French)

Note: the message "None alternative signature" is better than original, because we can select an algorithm, then select back this first option. It is not the same behavior than the Crypto Token drop list one.

Before
EJBCA_Admin-GUI_Signing-algorithm_1-BEFORE

After
EJBCA_Admin-GUI_Signing-algorithm_2-AFTER

How has this been tested?

Tested in Web GUI.

Checklist before the review request

  • I have performed a self-review of my code
  • I have kept the patch limited to only change the parts related to the patch
  • This change requires a documentation update

@primetomas
Copy link
Collaborator

I like the localization, but not the change to "None alternative signature". The original text makes it very easy to understand imho, while the new one makes it sounds like you should select one.

@Realiserad
Copy link
Contributor

Realiserad commented Jan 21, 2025

Some feedback from someone who has not been using EJBCA in a while.

I can see where David is coming from. Suppose admin A picks an alternative signing algorithm in the dropdown. Two days later, admin B is told to disable the alternative signature. When he goes into the GUI it is unclear that "disabling the alternative signature" means picking "Select an algorithm" in the dropdown.

I don't think "- None alternative signature -" is grammatically correct though. Should probably be "- No alternative signature -". Personally I think that's an improvement over what we have now.

@primetomas
Copy link
Collaborator

That is not a possible use case. Once the CA has been created it is not possible to edit the CA an unselect the alternative algorithm. I.e. once you created your hybrid CA there is no going back (actually there is in using the CLI, but then you really know what you're doing anyway).

@dcarella
Copy link
Contributor Author

In "Approval Settings" (in this same form), there are drop down lists, and I don't think that anyone think "I should select one".
Maybe, like "Approval Settings", the first item should be "None" (even if "No" it's better: I agree with @Realiserad).

@primetomas
Copy link
Collaborator

You have not presented a good argument to change it imho. The only argument I can read above is that it "should look like the other drop-downs". I am pretty sure, all my experience says so, that we will get support issues if it looks like a "normal" drop down. This is not a normal drop down. I'd rather have more hoops to go through in order to activate hybrid than less. The help text below is not visible enough for warnings.

Can you make the final decision @mike-agrenius-kushner .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants