fixed bug that was stripping slashes from mountpoint for HCVPKI #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joevanwanzeeleKF
commented
Nov 22, 2024
joevanwanzeeleKF
commented
- HCVPKI no longer removes slashes from mount points that include them
- HCVPKI store type definition now includes "needs server" to be checked
-
- This allows the URL and token to be passed the same way as it is for the HCVKV* store types
-
- Vault host URL is passed in the SERVER USERNAME field
-
- Vault Token is passed in the SERVER PASSWORD field.
- HCVPKI store type definition no longer includes VaultServerURL
…ype definition for HCVPKI
…ashicorp-vault-orchestrator into mount_point_path_fix
kf-bnewton
reviewed
Nov 25, 2024
doebrowsk
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.