Transaction support for signing and timed service #76
Conversation
…est_certificate_in_performance_test_client_from_branch_5' into 'branch-5' DSS-2522: Options to chose hash algorithm and get certificate in TSA response... See merge request signserver/signserver!153 (cherry picked from commit 8737ecb23248a2e1bae60f8781bce11546c0ef2c) 6bc660d9 DSS-2522: Options to chose hash algorithm and get certificate in TSA response... ab08da07 DSS-2522: Formatting fix a84b6d72 DSS-2522: Formatting fix. Tabs changed to spaces in the entire file. 6a48fe25 DSS-2522: Throw exception if the requested digest algorithm is not supported.
Merge DSS-2522 from branch-5 to main See merge request signserver/signserver!161
DSS-2547: branch-5 to main See merge request signserver/signserver!163
Merge old commits from branch-5 to main See merge request signserver/signserver!164
DSS-2566: Drop support for OOXML signer See merge request signserver/signserver!158
DSS-2567: Drop support for ODF signer See merge request signserver/signserver!160
DSS-2527: branch-5 to main See merge request signserver/signserver!166
DSS-2558: branch-5 to main See merge request signserver/signserver!167
DSS-2512: Add scope compile for Log4J dependencies See merge request signserver/signserver!168
DSS-2529: branch-5 to main See merge request signserver/signserver!170
DSS-2579: Add script for installing files to Maven See merge request signserver/signserver!171
DSS-2104: Remove AdminGUI standalone application See merge request signserver/signserver!169
DSS-2552: Upgrade to Jakarta EE 8 API See merge request signserver/signserver!177
# Conflicts: # signserver/modules/SignServer-Test-AdminWS/pom.xml
DSS-2568: Support for running on java 17 See merge request signserver/signserver!181
DSS-2577: Merge branch-5 to main See merge request signserver/signserver!183
DSS-2552: upgrade to jakarta EE 8 api See merge request signserver/signserver!184
Make the compliance tests expect the new POSIX warning from newer versions of jarsigner.
DSS-2458: support wf26 See merge request signserver/signserver!182
DSSINTER-1044: Custom header check added for CSRF protection + Some OpenAPI and Javadoc updates See merge request signserver/signserver!297
…t_the_result' into 'main' DSS-2633: performance stresstest client does not print the result See merge request signserver/signserver!304
Updated Security policy, added Issue templates
|
Hi! This looks very interesting! There's quite a lot of whitespace/formatting changes that are unrelated to the actual feature. Thanks! |
It was automatically formatted by IDE I believe, I will try to remove it and keep it clear. |
|
@mlundblad hopefully the formatting is better now. |
|
@mlundblad I am just wondering if this PR is ok and will be merged into the main branch. Is there anything I should clarify? |
|
There are a lot of commits in this PR, maybe it needs to be rebased? |
|
Perhaps the large amount of commits could be due to have we handle the Git repository? @3keyroman Assuming f556d526df9663c7c2434c2c536aa24eb442c036 is the only relevant commit for this PR?, then there are still a number of whitespace and formatting changes that would be good to leave out to make it easier to review and to discuss further. |
|
@netmackan my last commit resolving the whitespaces and formatting was a5696d3. I am not able to do merge or rebase because of the same conflicts with the |
|
@3keyroman Ok, thanks I see it now. This is likely an issue with our repo. I think I need to create a new PR and just add your commit(s). |
|
The 3 relevant commits in order seems to be: |
|
I can make a new PR from the current main branch if you want, we have done few updates to implementation so it might be worth. What do you think? |
Sounds good. I did try doing that with #110 but it is better if it comes from you so we can delete that one then. |
There are use cases, when siging worker needs to be executed in transaction because it interacts with the database. Typically, when the keys are stored in the database, or some other information needs to be updated during signing execution.
This implementation introduces feature to turn on the transaction handling for other use cases then for key usage counter or archiving. Specifically for signing and timed services.
There is a new interface
requiresTransactionimplemented, which isfalseby default.