Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

171 implement multi table helper functions #180

Merged
merged 12 commits into from
Sep 16, 2024
Merged

171 implement multi table helper functions #180

merged 12 commits into from
Sep 16, 2024

Conversation

folmos-at-orange
Copy link
Member

@folmos-at-orange folmos-at-orange commented Apr 15, 2024 •
edited by popescu-v
Loading

Closes #171

@folmos-at-orange folmos-at-orange linked an issue Apr 15, 2024 that may be closed by this pull request
Implement multi-table helper functions #171
Closed
@folmos-at-orange folmos-at-orange force-pushed the 171-implement-multi-table-helper-functions branch 3 times, most recently from 8f61f0e to e15bd6d Compare April 25, 2024 15:59
@folmos-at-orange folmos-at-orange force-pushed the 171-implement-multi-table-helper-functions branch from e15bd6d to 47c2b90 Compare May 3, 2024 12:40
@folmos-at-orange folmos-at-orange force-pushed the 171-implement-multi-table-helper-functions branch 5 times, most recently from 31ea278 to 331a97d Compare June 12, 2024 08:11
@folmos-at-orange folmos-at-orange force-pushed the 171-implement-multi-table-helper-functions branch 12 times, most recently from c63cbfc to 6de0725 Compare June 20, 2024 12:55
@folmos-at-orange folmos-at-orange force-pushed the 171-implement-multi-table-helper-functions branch 2 times, most recently from 492abf0 to 98298d3 Compare June 25, 2024 06:17
@folmos-at-orange folmos-at-orange force-pushed the 171-implement-multi-table-helper-functions branch from 98298d3 to ab39277 Compare July 4, 2024 08:36
@folmos-at-orange folmos-at-orange modified the milestones: 10.2.2.1, 10.2.2.2 Jul 4, 2024
@folmos-at-orange folmos-at-orange force-pushed the 171-implement-multi-table-helper-functions branch from ab39277 to 94d2bfc Compare July 5, 2024 06:31
@folmos-at-orange folmos-at-orange force-pushed the 171-implement-multi-table-helper-functions branch 2 times, most recently from dbbf373 to 7ef339f Compare August 28, 2024 15:48
@folmos-at-orange folmos-at-orange force-pushed the 171-implement-multi-table-helper-functions branch 2 times, most recently from 51d5c2f to f3253b3 Compare September 4, 2024 13:18
@folmos-at-orange folmos-at-orange force-pushed the 171-implement-multi-table-helper-functions branch from f3253b3 to 1112211 Compare September 9, 2024 14:28
@folmos-at-orange folmos-at-orange mentioned this pull request Sep 9, 2024
Closed
@lucaurelien lucaurelien self-requested a review September 12, 2024 08:28
@folmos-at-orange folmos-at-orange force-pushed the 171-implement-multi-table-helper-functions branch from 1112211 to 9716d65 Compare September 13, 2024 16:15
popescu-v
popescu-v requested changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@popescu-v popescu-v left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide further explanations in two commit messages:

  • commit: 1bbae13 : provide explanation of what the refactoring consists of and, more important, provide rationale for why this was necessary.
  • commit 9047000 : explain briefly what the simplification consists of, and why it was necessary (in this PR)

@folmos-at-orange
Refactor dataset dictionary spec methods
78f91a2 
- Move the dataset spec check methods out of the Dataset class
- Simplify the messages of the aformentioned check errors
  - In particular eliminate all referenoces to `X` or `y`
- Add a few new tests to `tests/test_dataset_errors.py`
- Uniformize the pattern of the `tests/test_dataset_errors.py` tests
@folmos-at-orange
Undeprecate file-based datasets
40f0d2a
@folmos-at-orange
Use Khiops to detect type for file datasets
dbb4a5a 
Also:
- Simplification of the dictionary dataset tests
- Add exceptions to dictionary dataset fixtures
- Use a fixed seed for the generated data
@folmos-at-orange
Add file name parameter to estimator _transform method
5f4adb5
@folmos-at-orange
Implement multi-table sort helper function
8cbea79
@folmos-at-orange
Abbreviate dataset variables to ds
4eb8cc6
@folmos-at-orange
Move target_column from tables to dataset
c0b68b6
@folmos-at-orange
Ease conditions for input in predict* methods
fd6a909 
Before this commit input tables needed to have the same number of
columns, names and types as the model dictionary. The columns needed
also to be in the same order.

Now the conditions are the following for the predict* and transform
methods:
- Columns must have the same names regardless the order of the input
  table.
  - An additional flexibility with supervised models: the target column
    may be present in the input table.
- The types must be the same for the input but the following case is
  allowed:
  - If a given column has Numerical type as input but the model is
    Categorical, then it is coerced to categorical with a warning.
@folmos-at-orange
Implement train/test split dataset function
6ddb43d
@folmos-at-orange
Update documentation
2d56546
@folmos-at-orange
Simplify Dataset state variables
07c0a7f 
- Remove `target_column_type` and `target_column_dtype` members
- Make `is_in_memory` and `is_multitable` properties
- Minor changes in comments and renamings
@folmos-at-orange
Update CHANGELOG.md
558866c
@folmos-at-orange folmos-at-orange force-pushed the 171-implement-multi-table-helper-functions branch from 9716d65 to 558866c Compare September 13, 2024 16:27
@folmos-at-orange folmos-at-orange merged commit 4ae7f30 into dev Sep 16, 2024
20 checks passed
@folmos-at-orange folmos-at-orange deleted the 171-implement-multi-table-helper-functions branch September 16, 2024 03:56
@folmos-at-orange folmos-at-orange restored the 171-implement-multi-table-helper-functions branch September 18, 2024 16:09
@popescu-v popescu-v mentioned this pull request Oct 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popescu-v popescu-v popescu-v approved these changes

@lucaurelien lucaurelien Awaiting requested review from lucaurelien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement multi-table helper functions
2 participants
@folmos-at-orange @popescu-v