171 implement multi table helper functions (second round) #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folmos-at-orange
force-pushed
the
171-implement-multi-table-helper-functions
branch
2 times, most recently
from
a2d8df1 to
8af29c8
Compare
popescu-v
reviewed
Oct 21, 2024
popescu-v
reviewed
Oct 21, 2024
popescu-v
reviewed
Oct 21, 2024
popescu-v
reviewed
Oct 21, 2024
popescu-v
reviewed
Oct 21, 2024
popescu-v
reviewed
Oct 21, 2024
popescu-v
reviewed
Oct 21, 2024
popescu-v
reviewed
Oct 21, 2024
popescu-v
reviewed
Oct 21, 2024
folmos-at-orange
force-pushed
the
171-implement-multi-table-helper-functions
branch
2 times, most recently
from
8b0b70b to
d5a9366
Compare
popescu-v
reviewed
Oct 22, 2024
popescu-v
reviewed
Oct 22, 2024
popescu-v
reviewed
Oct 22, 2024
popescu-v
reviewed
Oct 22, 2024
folmos-at-orange
force-pushed
the
171-implement-multi-table-helper-functions
branch
3 times, most recently
from
82d9b1d to
31208f5
Compare
popescu-v
reviewed
Oct 23, 2024
- Move the dataset spec check methods out of the Dataset class - Simplify the messages of the aformentioned check errors - In particular eliminate all referenoces to `X` or `y` - Add a few new tests to `tests/test_dataset_errors.py` - Uniformize the pattern of the `tests/test_dataset_errors.py` tests
Also: - Simplification of the dictionary dataset tests - Add exceptions to dictionary dataset fixtures - Use a fixed seed for the generated data
Before this commit input tables needed to have the same number of
columns, names and types as the model dictionary. The columns needed
also to be in the same order.
Now the conditions are the following for the predict* and transform
methods:
- Columns must have the same names regardless the order of the input
table.
- An additional flexibility with supervised models: the target column
may be present in the input table.
- The types must be the same for the input but the following case is
allowed:
- If a given column has Numerical type as input but the model is
Categorical, then it is coerced to categorical with a warning.
- Remove `target_column_type` and `target_column_dtype` members - Make `is_in_memory` and `is_multitable` properties - Minor changes in comments and renamings
folmos-at-orange
force-pushed
the
171-implement-multi-table-helper-functions
branch
from
31208f5 to
d386853
Compare
folmos-at-orange
force-pushed
the
171-implement-multi-table-helper-functions
branch
from
d386853 to
863e189
Compare
folmos-at-orange
deleted the
171-implement-multi-table-helper-functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.