Ekran skanowania wyszukaj #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D3bi7
commented
Dec 17, 2024
•
D3bi7
commented
WezSieTato
requested changes
Dec 19, 2024
lib/pages/scan/scan.dart
Outdated
| textAlign: TextAlign.center, | ||
| style: TextStyle(color: Colors.white), | ||
| child: Container( | ||
| width: 328, |
There was a problem hiding this comment.
Nie ustawiaj sztywno szerokości i wysokości, tylko ustaw odpowiednie paddingi. NA podstawie wielkości tekstu i szerokości ekranu, widok sam powienien się przeskalować.
lib/pages/scan/scan.dart
Outdated
| padding: | ||
| const EdgeInsets.only(left: 20.0, right: 10), | ||
| child: SvgPicture.asset( | ||
| 'assets/search.svg', |
There was a problem hiding this comment.
Wygeneruj plik z assetami z niego korzystaj, nie podawaj ścieżek ręcznie.
# Conflicts: # lib/pages/detail/logotypes.dart # lib/pages/scan/scan_background.dart
WezSieTato
requested changes
Dec 29, 2024
| ), | ||
| Expanded( | ||
| child: Text( | ||
| 'Wyszukaj', |
| child: Text( | ||
| 'Wyszukaj', | ||
| style: TextStyle( | ||
| fontSize: 16, |
There was a problem hiding this comment.
Tu powinień być użyty TextSize.mediumTitle
| @@ -71,19 +71,41 @@ class _MainPageState extends State<MainPage> { | |||
| children: <Widget>[ | |||
| _buildQrView(context), | |||
| SafeArea( | |||
There was a problem hiding this comment.
Możesz wynieść ten cały obiekt do nowego widgetu? Np. ScanSearchButton. Wszystko co odpowada za ten guzik, żeby było w oddzielnym pliku.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.