Expression based cursor #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pathaknv
approved these changes
May 22, 2023
| # Here we build the rank_value for each returned row | ||
| schema, :rank_value -> | ||
| {:ok, %{rows: [[rank_value]]}} = | ||
| Repo.query("SELECT ts_rank($1, plainto_tsquery('simple', $2))", [ |
There was a problem hiding this comment.
@richardrissanen does this execute a new query per row?
There was a problem hiding this comment.
That example does but I am sticking with our function based solution. However, there is a select merge that is required with this solution.
There was a problem hiding this comment.
@richardrissanen got it. I think given the fact that this is a PR against the existing repo, and seems others have used it w success, I'm much less worried about the change
jonbirke0927
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this solution via the repos issues here: duffelhq#173