Skip to content

Commit

Permalink
quick bug fix
Browse files Browse the repository at this point in the history
  • Loading branch information
Koeng101 committed Oct 6, 2024
1 parent 0b725d7 commit 6847356
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/synthesis/fragment/fragment.go
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ func RecursiveFragment(sequence string, maxCodingSizeOligo int, assemblyPattern
}
var fragmentsAppended []string
for _, fragment := range fragments {

Check failure on line 295 in lib/synthesis/fragment/fragment.go

View workflow job for this annotation

GitHub Actions / lint

S1011: should replace loop with `fragmentsAppended = append(fragmentsAppended, fragments...)` (gosimple)
fragmentsAppended = append(fragmentsAppended, forwardFlank+fragment+reverseFlank)
fragmentsAppended = append(fragmentsAppended, fragment)
}
return Assembly{Sequence: sequence, Fragments: fragmentsAppended, Efficiency: efficiency}, nil
}
Expand Down
2 changes: 1 addition & 1 deletion py/tests/test_fragment.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,4 @@ def test_recursive_fragment():
result = recursive_fragment(gene, max_oligo_len, assembly_pattern, exclude_overhangs, default_overhangs, "GTCTCT", "CGAG")
assert result is not None, "RecursiveFragment failed"
# Add more specific assertions based on the expected structure of the result
assert result.fragments == ['GTCTCTGTCTCTATGACCATGATTACGCCAAGCTTGCATGCCTGCAGGTCGACTCTAGAGGATCCCCGGGTACCGAGCTCGAATTCACTGGCCGTCGTTTTACAACGTCGTGACTGGGAAAACCCTGGCGTTACCCAACTTAATCGCCTTGCAGCACATCCCCCTTTCGCCAGCGAG', 'GTCTCTCCAGCTGGCGTAATAGCGAAGAGGCCCGCACCGATCGCCCTTCCCAACAGTTGCGCAGCCTGAATGGCGAATGGCGCCTGATGCGGTATTTTCTCCTTACGCATCTGTGCGGTATTTCACACCGCATATGGTGCACTCTCAGTACAATCTGCTCTGATGCCGCATAGCGAGCGAG']
assert result.fragments == ['GTCTCTATGACCATGATTACGCCAAGCTTGCATGCCTGCAGGTCGACTCTAGAGGATCCCCGGGTACCGAGCTCGAATTCACTGGCCGTCGTTTTACAACGTCGTGACTGGGAAAACCCTGGCGTTACCCAACTTAATCGCCTTGCAGCACATCCCCCTTTCGCCAGCGAG', 'CCAGCTGGCGTAATAGCGAAGAGGCCCGCACCGATCGCCCTTCCCAACAGTTGCGCAGCCTGAATGGCGAATGGCGCCTGATGCGGTATTTTCTCCTTACGCATCTGTGCGGTATTTCACACCGCATATGGTGCACTCTCAGTACAATCTGCTCTGATGCCGCATAGCGAG']

0 comments on commit 6847356

Please sign in to comment.