Sync v0.9.0 dev into piratedex #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the SelectCoinsPage to automatically select and activate "ARRR" to show the ZHTLC activation popup dialog, if it has not been shown already. Add a column to the `Wallet` and `CurrentWallet` tables in the SQLite database to record whether the ZHTLC coin activation popup was displayed.
Delist THC and update coins hash
kivqa
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Approved.
Checked on iOS and Android:
- icons and references are correct
- ZHTLC activation dialog appears as expected on wallet create/import
- ZHTLC Activation interruption handled as expected
- Default coins ARRR and ARRR-BEP20 added
- ARRR - KMD swap completed successfully
CharlVS
approved these changes
Jan 30, 2024
smk762
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Functions as expected for activation & incoming / outgoing swaps / transactions.
ToS etc updated to target as expected.
Zombie faucet functions as expected.
Awaiting logo change, but otherwise lgtm!
Minor cosmetic change: instead of "getting transaction" when initiating a withdraw, "generating transaction" or "creating transaction" would be more accurate. The former implies transaction exists and is being grabbed from history.
* Migrate BestOrders to mmrpc 2.0 Leaving the BestOrder and BestOrders attributes unchanged to minimise the impact * Fix empty best orders list ARRR has no `address_data` as it is a `Shielded` address, so we cannot use address to filter ARRR top orders.
|
@takenagain we need to update logo for mobile app (requirement of Pirate): https://github.com/PirateNetwork/mediakit/blob/main/Coin/SVG/Pirate_Logo_Coin_Gold.svg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebrands the following items to match Pirate branding
Logos and Symbols were obtained from Pirate Network mediakit
Sync changes from dev: