Prefer SSL coin electrum servers #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlVS
changed the title
`coins_config_ssl` delists coins without SSL support whereas `coins_config_tcp` favours SSL but falls back to TCP if not available.
Signed-off-by: Charl (Nitride) <[email protected]>
ca333
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer SSL electrum servers, but fall back to TCP where no SSL electrum is listed.
NB: Monitor stability post-release for reports of expired cert issues. If it's a common issue, consider reverting back to TCP-only.
Also, this brings a significant benefit where the Defi API binary will use half the previous number of file descriptors. This was the primary limitation requiring us to introduce the limit of the number of activated coins on mobile. Monitor the stability post-launch and consider increasing the limit once we are sure of the fix's stability. I'm also leaving the limit unchanged for now to see if it resolves the difficult-to-reproduce iOS (primarily, but also some Android reports) crash we've been chasing for a while.