Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZHTLC Hide Cancel button for Resyncing Progress #72

Merged
merged 3 commits into from
Oct 10, 2023
Merged

ZHTLC Hide Cancel button for Resyncing Progress #72

merged 3 commits into from
Oct 10, 2023

Conversation

naezith
Copy link
Collaborator

@naezith naezith commented Oct 9, 2023

Currently, the resyncing is cancellable on the progress pop-up.

With these changes, we show the cancel/stop button only if all the coins to activate exist in the enabled coins list.

@naezith naezith requested review from ca333 and CharlVS October 9, 2023 10:00
@CharlVS CharlVS requested a review from kivqa October 9, 2023 10:58
@CharlVS CharlVS added the QA Ready for QA testing label Oct 9, 2023
kivqa
kivqa approved these changes Oct 9, 2023
View reviewed changes
Copy link

@kivqa kivqa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Resync pop up does not contains Stop (cancel activation) button .
image

No regression was observed for main activation flow

@CharlVS CharlVS force-pushed the zhtlc-resync-no-cancel branch from 1647324 to 097aa1e Compare October 10, 2023 11:44
@CharlVS CharlVS merged commit fedad06 into dev Oct 10, 2023
1 check failed
@CharlVS CharlVS deleted the zhtlc-resync-no-cancel branch October 10, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kivqa kivqa kivqa approved these changes

@CharlVS CharlVS CharlVS approved these changes

@ca333 ca333 Awaiting requested review from ca333

Assignees
No one assigned
Labels
QA Ready for QA testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naezith @CharlVS @kivqa