Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proxy-wasm) support get 'plugin_name' in tick context #667

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

thibaultcha
Copy link
Member

No filter chain initialized on tick contexts means the root context must be stored in the empty filter chain context for later retrieval.

No filter chain initialized on tick contexts means the root context must
be stored in the empty filter chain context for later retrieval.
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.82100%. Comparing base (6138510) to head (1e3067c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #667         +/-   ##
===================================================
- Coverage   90.83814%   90.82100%   -0.01714%     
===================================================
  Files             53          53                 
  Lines          11275       11352         +77     
  Branches        1671        1691         +20     
===================================================
+ Hits           10242       10310         +68     
- Misses          1027        1036          +9     
  Partials           6           6                 
Files with missing lines Coverage Δ
src/common/proxy_wasm/ngx_proxy_wasm.c 92.70947% <100.00000%> (+0.02387%) ⬆️
src/common/proxy_wasm/ngx_proxy_wasm.h 92.30769% <ø> (ø)
src/common/proxy_wasm/ngx_proxy_wasm_properties.c 89.76035% <100.00000%> (+0.04480%) ⬆️

... and 2 files with indirect coverage changes

Flag Coverage Δ
unit 90.56263% <100.00000%> (-0.01753%) ⬇️
valgrind 82.47734% <37.50000%> (+0.00853%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@thibaultcha thibaultcha merged commit fa0cd87 into main Jan 20, 2025
32 checks passed
@thibaultcha thibaultcha deleted the fix/plugin-name-property branch January 20, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant