-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polynomial Spectral Phase element #263
Merged
MaxThevenet
merged 25 commits into
LASY-org:development
from
soerenjalas:spectral_phase
Jul 31, 2024
Merged
Polynomial Spectral Phase element #263
MaxThevenet
merged 25 commits into
LASY-org:development
from
soerenjalas:spectral_phase
Jul 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
reviewed
Jul 16, 2024
RemiLehe
reviewed
Jul 16, 2024
Closes #223 |
Co-authored-by: Remi Lehe <[email protected]>
Co-authored-by: Remi Lehe <[email protected]>
Thanks for this PR.
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
MaxThevenet
reviewed
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for this PR! See comments below.
Thanks for catching these typos @MaxThevenet! |
MaxThevenet
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #261 first!
This PR adds an optical element that allows to add spectral phase parametrized through the Taylor series coefficients GDD, TOD, and FOD.
Description edited by @RemiLehe:
I added two automated test: