Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call fully qualified date on Darwin #19

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Call fully qualified date on Darwin #19

merged 1 commit into from
Sep 25, 2024

Conversation

johanfriis
Copy link
Contributor

When GNU coreutils are installed and in the users $PATH, using date unqualified will lead to errors, as -j is an invalid option.

When GNU coreutils are installed and in the users $PATH, using `date` unqualified will lead to errors, as -j is an invalid option.
@jhd-lego
Copy link
Collaborator

Interesting, how did you install coreutils?
I do have GNU coreutils installed through Homebrew. Homebrew explicitly adds a g infront of each util to ensure it doesn't clash in this way.
I think this is a fair change though.

@jhd-lego jhd-lego merged commit 760447b into LEGO:main Sep 25, 2024
3 checks passed
@johanfriis
Copy link
Contributor Author

johanfriis commented Sep 29, 2024

Yeah, I think it's safe to point explicitly to /bin/date on MacOS since that is the default there. I would be more wary on a linux system.

Regarding the clash, I am one of those less careful individuals that adds gnubin to the head of his PATH 😶‍🌫️. I have done this for the past ~10 years I guess, and I think I can count on one hand the amount of times it has bit me. I just dislike the BSD coreutils that much 😅

Anyways, thanks for the quick merge 🫡

@johanfriis
Copy link
Contributor Author

@jhd-lego Sorry to bother you again, but do you think this change would merit bumping the version and running a new release?

@johanfriis johanfriis deleted the fully-qualified-date branch September 30, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants