Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/new tables #359

Merged
merged 12 commits into from
Oct 28, 2023
Merged

Feature/new tables #359

merged 12 commits into from
Oct 28, 2023

Conversation

drreynolds
Copy link
Collaborator

Steven and I added some additional embedded explicit Runge--Kutta methods to ARKODE.

CHANGELOG.md Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Outdated Show resolved Hide resolved
@gardner48
Copy link
Member

The single precision builds are currently failing with the errors below. I assume the actual table values are within the single precision range and just the rational expressions have constants that are not. Should we note this in the documentation? I'll update some of the CI testing flags shortly.

/var/lib/jenkins/workspace/SUNDIALS_GitHub_Test_PR-359/test/tarballs/sundials-6.6.1/src/arkode/arkode_butcher_erk.def:673:1: error: floating constant exceeds range of 'float' [-Werror=overflow]
 ARK_BUTCHER_TABLE(ARKODE_VERNER_9_5_6, { /* Verner-6-5b (DOI: 10.1007/s11075-009-9290-3) */
 ^
/var/lib/jenkins/workspace/SUNDIALS_GitHub_Test_PR-359/test/tarballs/sundials-6.6.1/src/arkode/arkode_butcher_erk.def:733:1: error: floating constant exceeds range of 'float' [-Werror=overflow]
 ARK_BUTCHER_TABLE(ARKODE_VERNER_10_6_7, { /* Verner-7-6 (DOI: 10.1007/s11075-009-9290-3) */
 ^
/var/lib/jenkins/workspace/SUNDIALS_GitHub_Test_PR-359/test/tarballs/sundials-6.6.1/src/arkode/arkode_butcher_erk.def:802:1: error: floating constant exceeds range of 'float' [-Werror=overflow]
 ARK_BUTCHER_TABLE(ARKODE_VERNER_13_7_8, { /* Verner-8-7 (DOI: 10.1007/s11075-009-9290-3) */

@drreynolds
Copy link
Collaborator Author

drreynolds commented Oct 27, 2023

The single precision builds are currently failing with the errors below. I assume the actual table values are within the single precision range and just the rational expressions have constants that are not. Should we note this in the documentation? I'll update some of the CI testing flags shortly.

/var/lib/jenkins/workspace/SUNDIALS_GitHub_Test_PR-359/test/tarballs/sundials-6.6.1/src/arkode/arkode_butcher_erk.def:673:1: error: floating constant exceeds range of 'float' [-Werror=overflow]
 ARK_BUTCHER_TABLE(ARKODE_VERNER_9_5_6, { /* Verner-6-5b (DOI: 10.1007/s11075-009-9290-3) */
 ^
/var/lib/jenkins/workspace/SUNDIALS_GitHub_Test_PR-359/test/tarballs/sundials-6.6.1/src/arkode/arkode_butcher_erk.def:733:1: error: floating constant exceeds range of 'float' [-Werror=overflow]
 ARK_BUTCHER_TABLE(ARKODE_VERNER_10_6_7, { /* Verner-7-6 (DOI: 10.1007/s11075-009-9290-3) */
 ^
/var/lib/jenkins/workspace/SUNDIALS_GitHub_Test_PR-359/test/tarballs/sundials-6.6.1/src/arkode/arkode_butcher_erk.def:802:1: error: floating constant exceeds range of 'float' [-Werror=overflow]
 ARK_BUTCHER_TABLE(ARKODE_VERNER_13_7_8, { /* Verner-8-7 (DOI: 10.1007/s11075-009-9290-3) */

I don't see why I can't comment in-line to this item, so I'm answering in a separate comment.

Yes, I think that the issue is that the coefficients are provided in rational form, with components that have a large number of digits. I will convert these to 40-digit decimals to inhibit these warnings (I think I can easily do this with the Matlab analysis script infrastructure that I built).

@drreynolds drreynolds requested a review from gardner48 October 27, 2023 20:03
balos1
balos1 previously approved these changes Oct 27, 2023
@balos1 balos1 added this to the SUNDIALS Next milestone Oct 27, 2023
gardner48
gardner48 previously approved these changes Oct 27, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
gardner48 and others added 2 commits October 27, 2023 20:47
Co-authored-by: Steven Roberts <[email protected]>
Remove duplicate change log entry
gardner48 added a commit to sundials-codes/answers that referenced this pull request Oct 28, 2023
@gardner48 gardner48 merged commit 6c60a56 into develop Oct 28, 2023
14 checks passed
@gardner48 gardner48 deleted the feature/new-tables branch October 28, 2023 23:59
balos1 pushed a commit that referenced this pull request Nov 3, 2023
 Additional embedded explicit Runge--Kutta
methods to ARKODE.

---------

Co-authored-by: Steven Roberts <[email protected]>
Co-authored-by: David J. Gardner <[email protected]>
gardner48 added a commit that referenced this pull request Dec 18, 2023
 Additional embedded explicit Runge--Kutta
methods to ARKODE.

---------

Co-authored-by: Steven Roberts <[email protected]>
Co-authored-by: David J. Gardner <[email protected]>
balos1 pushed a commit that referenced this pull request Dec 18, 2023
 Additional embedded explicit Runge--Kutta
methods to ARKODE.

---------

Co-authored-by: Steven Roberts <[email protected]>
Co-authored-by: David J. Gardner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants