CMake: Fix dll install location #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschueller
requested review from
balos1,
gardner48,
cswoodward and
drreynolds
as code owners
|
The same issue is solved slightly differently with a patch in MSYS2: But admittedly, I prefer your proposed change. |
|
didnt know that omitting DESTINATION is equivalent, lets use new features when they are available (seems to be from cmake>=3.14 but sundials requires >=3.18 anyways) |
balos1
requested changes
May 15, 2024
There was a problem hiding this comment.
Just a couple request w.r.t. the change notes. Please also sign your commit as per our Contributing guide.
balos1
reviewed
May 15, 2024
balos1
reviewed
May 15, 2024
Signed-off-by: Julien Schueller <[email protected]>
balos1
approved these changes
May 16, 2024
gardner48
pushed a commit
that referenced
this pull request
Jun 20, 2024
This fixes dll search on conda where dlls are expected to be installed in prefix/bin (pretty standard layout) static or import libs still go to prefix/lib Signed-off-by: Julien Schueller <[email protected]> Co-authored-by: Cody Balos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes dll search on conda where dlls are expected to be installed in prefix/bin (pretty standard layout)
static or import libs still go to prefix/lib