Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Default IMEX-MRI method #567

Closed
wants to merge 3 commits into from
Closed

Bugfix: Default IMEX-MRI method #567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
331f137
fix bug in setting IMEX-MRI methods
gardner48 Sep 10, 2024
3350af4
update recent changes
gardner48 Sep 10, 2024
305df0a
single quotes in markdown
gardner48 Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ architecture for their system.

Fixed the loading of ARKStep's default first order explicit method.

Fixed loading the default IMEX-MRI method if `ARKodeSetOrder` is used to
specify a third or fourth order method. Previously, the default second order
method was loaded in both cases.

Fixed a CMake bug regarding usage of missing "print_warning" macro
that was only triggered when the deprecated `CUDA_ARCH` option was used.

Expand Down
4 changes: 4 additions & 0 deletions doc/shared/RecentChanges.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ override this value with the architecture for their system.

Fixed the loading of ARKStep's default first order explicit method.

Fixed loading the default IMEX-MRI method if :c:func:`ARKodeSetOrder` is used to
specify a third or fourth order method. Previously, the default second order
method was loaded in both cases.

Fixed a CMake bug regarding usage of missing "print_warning" macro
that was only triggered when the deprecated ``CUDA_ARCH`` option was used.

Expand Down
4 changes: 2 additions & 2 deletions src/arkode/arkode_mristep.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1759,8 +1759,8 @@ int mriStep_SetCoupling(ARKodeMem ark_mem)
{
case 1: table_id = MRISTEP_DEFAULT_IMEX_SD_1; break;
case 2: table_id = MRISTEP_DEFAULT_IMEX_SD_2; break;
case 3: table_id = MRISTEP_DEFAULT_IMEX_SD_2; break;
case 4: table_id = MRISTEP_DEFAULT_IMEX_SD_2; break;
case 3: table_id = MRISTEP_DEFAULT_IMEX_SD_3; break;
case 4: table_id = MRISTEP_DEFAULT_IMEX_SD_4; break;
}

/**** implicit methods ****/
Expand Down
Loading