Bugfix: RHS eval logic with certain IMEX methods #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardner48
requested review from
balos1,
cswoodward and
drreynolds
as code owners
|
This did not impact any of the methods currently in ARKODE but would effect user supplied tables. The methods @drreynolds added in the |
drreynolds
reviewed
Dec 19, 2024
drreynolds
added a commit
that referenced
this pull request
Dec 19, 2024
Fix typos in recent changes Co-authored-by: Daniel R. Reynolds <[email protected]>
drreynolds
approved these changes
Dec 19, 2024
balos1
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in ARKStep where an extra right-hand side evaluation occurs each time step when enabling the
ARKodeSetAutonomousoption and using an IMEX method where the DIRK table has an implicit first and is not stiffly accurate. Fix a bug in counting the number of explicit RHS evaluations in the ARKStep Dahlquist unit test.