Hide unsafe code from the optimiser #160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type definition for
alternatives
is a record, so a clever compiler (such as Flambda 2) can assume that values of this type can never be equal to0
. This translates allalts == noalts
checks into trivialfalse
constants, eventually breaking down with a segfault whennoalts
is actually passed.My proposed fix is the minimal one: hide the constant
0
from the compiler, so it can't optimise away.The real fix is to use a variant definition. Example:
It's exactly the same runtime representation as the current one, but type-safe.