-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indexing via discrimination tree #205
Conversation
Looks much better than this morning. Do the tests pass if we always use the DT index? |
Most tests pass, but not all yet. I should look deeper to spot the bug.
And three failures:
|
Co-authored-by: Enrico Tassi <[email protected]>
Co-authored-by: Enrico Tassi <[email protected]>
src/data.ml
Outdated
@@ -181,6 +181,7 @@ and type t = (clause * int) list = struct | |||
type t = elt list [@@deriving show] | |||
|
|||
let get_time_stamp = snd | |||
let equal a b = a = b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should use the timestamp as a unique id, here you are comparing the clause "code" which can be large.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I totally agree
No description provided.