LibWeb: WebSocket fetch prep #3346
Open
+29
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only need a Page for file:// urls. At some point we probably needed it for other kinds of requests, but the current functionality doesn't need to store the Page pointer on the ResourceLoader.
A hygine patch to not use a generic = capture, and remove some unnecessary const-casts
ADKaster
force-pushed
the
websocket-fetch-infra
branch
from
eaa229e to
e15e6d1
Compare
There's nothing about this type that requires it to be GC allocated
ADKaster
force-pushed
the
websocket-fetch-infra
branch
from
e15e6d1 to
5a79973
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.