Fix underinvalidation of :nth-child using invalidation sets #3360
+63
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are tests where absence of newlines at EOF is important and required to check certain behavior.
kalenikaliaksandr
force-pushed
the
fix-nth-child-pseudo-class-underinvalidation
branch
from
ce5b036 to
ec5643a
Compare
kalenikaliaksandr
force-pushed
the
fix-nth-child-pseudo-class-underinvalidation
branch
2 times, most recently
from
7c7600c to
484b6e2
Compare
For all invalidation properties nested into nth-child argument list we need to invalidate whole subtree to make sure style of sibling elements will be recalculated.
kalenikaliaksandr
force-pushed
the
fix-nth-child-pseudo-class-underinvalidation
branch
from
484b6e2 to
719678b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all invalidation properties nested into nth-child argument list we need to invalidate whole subtree to make sure style of sibling elements will be recalculated.