Refactor main API files

[sweep-ai]

PR Feedback (click)

• 👍 Sweep Did Well
• 👎 Sweep Needs Improvement

Description

This PR aims to refactor the main API files, jhu-edu.js and korea-kcdc.js, in order to improve code structure, readability, and maintainability. The changes include extracting common logic into separate functions or modules, improving variable naming, and enhancing code organization.

Summary of Changes

• Refactored jhu-edu.js file:

  • Extracted common logic into separate functions to improve code reusability.
  • Improved variable naming for better clarity and understanding.
  • Reorganized code structure to enhance readability.

• Refactored korea-kcdc.js file:

  • Extracted common logic into separate functions to improve code reusability.
  • Improved variable naming for better clarity and understanding.
  • Reorganized code structure to enhance readability.

These changes aim to make the codebase more maintainable and easier to understand for future development and collaboration.

Fixes #31.

---

🎉 Latest improvements to Sweep:

• Getting Sweep to run linters before committing! Check out Sweep Sandbox Configs to set it up.
• Added support for self-hosting! Check out Self-hosting Sweep to get started.
• [Self Hosting] Multiple options to compute vector embeddings, configure your .env file using VECTOR_EMBEDDING_SOURCE

---

💡 To get Sweep to edit this pull request, you can:

• Leave a comment below to get Sweep to edit the entire PR
• Leave a comment in the code will only modify the file
• Edit the original issue to get Sweep to recreate the PR from scratch

[Laeyoung]

Sweep: please fix this crash

/Users/laeyoung/Documents/personal/COVID-19-API/api/korea-kcdc.js:4
const fetch = require("node-fetch");
^

Error [ERR_REQUIRE_ESM]: require() of ES Module /Users/laeyoung/Documents/personal/COVID-19-API/node_modules/node-fetch/src/index.js from /Users/laeyoung/Documents/personal/COVID-19-API/api/korea-kcdc.js not supported.

[sweep-ai]

🚀 Wrote Changes

Sweep: please fix this crash

/Users/laeyoung/Documents/personal/COVID-19-API/api/korea-kcdc.js:4
const fetch = require("node-fetch");
^

Error [ERR_REQUIRE_ESM]: require() of ES Module /Users/laeyoung/Documents/personal/COVID-19-API/node_modules/node-fetch/src/index.js from /Users/laeyoung/Documents/personal/COVID-19-API/api/korea-kcdc.js not supported.

Hi @Laeyoung,

I decided to make the following changes:

File Path	Proposed Changes
api/korea-kcdc.js	Rewrite api/korea-kcdc.js with contents: • Replace the line const fetch = require("node-fetch"); with import fetch from "node-fetch"; at the top of the file. • Replace all require() calls with import statements. For example, replace const express = require("express"); with import express from "express";. • Replace module.exports = router; with export default router; at the end of the file.

[Laeyoung]

Sweep: fix this issue

node server.js

Updated at 2023-09-23T07:40:08.560Z
/Users/laeyoung/Documents/personal/COVID-19-API/api/korea-kcdc.js:1
import express from "express";
^^^^^^

SyntaxError: Cannot use import statement outside a module

[sweep-ai]

🚀 Wrote Changes

Sweep: fix this issue

node server.js

Updated at 2023-09-23T07:40:08.560Z
/Users/laeyoung/Documents/personal/COVID-19-API/api/korea-kcdc.js:1
import express from "express";
^^^^^^

SyntaxError: Cannot use import statement outside a module

Hi @Laeyoung,

I decided to make the following changes:

File Path	Proposed Changes
api/korea-kcdc.js	Rewrite api/korea-kcdc.js with contents: • Replace the ES6 import statements at the top of the file with equivalent CommonJS require statements. For example, replace import express from "express"; with const express = require('express');. • Replace the ES6 export default router; statement at the bottom of the file with the equivalent CommonJS module.exports = router; statement.