Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lua, quest] Converts BRD unlock and BRD AF1 to IF #6682

Open
wants to merge 1 commit into
base: base
Choose a base branch
from

Conversation

CriticalXI
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Converts Path of the Bard and Painful Memory BRD quests to interaction framework

Path of the Bard: https://www.youtube.com/watch?v=ZAJAjoMJFdo
Painful Memory: https://www.youtube.com/watch?v=QXsns9eag10

Steps to test these changes

  • Complete A Minstrel in Despair quest either manually or through GM commands
  • Speak with Song Runes in Valkurm Dunes to complete Path of the Bard quest
  • Set yourself to BRD 40 to start Painful Memory quest and follow the quest steps

return quest:progressEvent(138)
elseif quest:getVar(player, 'initialCS') == 1 then
return quest:progressEvent(137)
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onTrigger = function(player, npc)
    local initialCS = quest:getVar(player, 'initialCS')
    if initialCS == 0 then
        return quest:progressEvent(138)
    elseif initialCS == 1 then
        return quest:progressEvent(137)
    end
end,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted to the example

return quest:noAction()
elseif
quest:getVar(player, 'nmKilled') == 1
then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theres only 1 condition here. Also, as above, store the variable in a local var instead of fetching it.

@CriticalXI CriticalXI force-pushed the brd_af1_painful_memory branch from 593cab2 to c3ce32d Compare January 10, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants