Week5 Assignment - Fix Calculator & Make NetworkModel #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leejun6694
reviewed
Sep 3, 2022
| @@ -9,6 +9,9 @@ import Foundation | |||
|
|
|||
| extension Numeric { | |||
| var exponentialNotation: String { | |||
| return Formatter.exponentialNotation.string(for: self) ?? "" | |||
| guard let exponentialNotationString = Formatter.exponentialNotation.string(for: self) else { | |||
| return "오류" | |||
leejun6694
reviewed
Sep 3, 2022
| let decimal = Int(decimalString), | ||
| var decimalFormat = numberFormatter.string(from: NSNumber(value: decimal)) | ||
| else { return "오류"} | ||
| if 1 < decimalFractionComponents.count, let fractionString = decimalFractionComponents.last { |
There was a problem hiding this comment.
1 < decimalFractionComponents.count
decimalFractionComponents.count > 1
위 두 코드를 우리는 어떻게 읽을까요?
- 1 보다 값이 큰 경우
- 값이 1보다 큰 경우
가독성을 고려해볼까요?
leejun6694
reviewed
Sep 3, 2022
| @@ -40,7 +43,14 @@ class CalculatorManager: ObservableObject { | |||
| // MARK: Method(s) | |||
|
|
|||
| func buttonColor(_ button: Button) -> (Color, Color) { | |||
There was a problem hiding this comment.
method 는 동작을 하는데, 네이밍에 동작이 없는 것 같습니다.
There was a problem hiding this comment.
Color 두개를 리턴하는데, method 만 보면 어떤걸 리턴하는지 유추하기 힘드네요
leejun6694
reviewed
Sep 3, 2022
| init?(htmlString: String) { | ||
| let option: [NSAttributedString.DocumentReadingOptionKey: NSAttributedString.DocumentType] = [.documentType: .html] | ||
| guard let htmlData = htmlString.data(using: .utf16), | ||
| let nsStr = try? NSAttributedString(data: htmlData, options: option, documentAttributes: nil) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculator
Network Module
예시 코드를 보고 네트워크 모듈을 설계해보고, 네이버 오픈 API를 사용해보았습니다.
코드를 참고하여 모듈을 설계하는 과정에서 AttributedString, URLComponents 등과 같은 생소한 메서드들이 많아 그 부분을 중점적으로 공부했습니다.
또한, 네트워크 모듈의 전체적인 로직을 이해하기위해 노력했습니다.
<요청을 하기 위한 메서드 로직>
이때, base주소가 동일하거나, 중복을 없애거나, 뒤에 다양한 경로가 올 수도 있기 때문에 URLComponents를 사용한다.
(메인 쓰레드에서 처리하지 않는 이유 → 메인 큐에서 동기적인 작업을 요청하면 데드락을 발생하는 경우가 생길 수도 있기 때문에 웬만하면 메인큐에서 sync를 하는 작업은 없어야 한다.)