Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+3 icons #2279

Merged
merged 3 commits into from
Aug 27, 2024
Merged

+3 icons #2279

merged 3 commits into from
Aug 27, 2024

Conversation

I21b
Copy link
Contributor

@I21b I21b commented Aug 23, 2024

Description

Icons addition information

Added

Cuberite (org.cuberite.android)
Custom Uploader (com.nyx.custom_uploader)
Look4Sat (com.rtbishop.look4sat)

Contributor's checklist

  • I followed the Lawnicons guidelines and will make changes if someone suggests. I will also make sure that Lawnicons builds correctly.

Copy link
Contributor

github-actions bot commented Aug 23, 2024

Thanks for your contribution!

While waiting for a review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons.

Canvas and sizes

  1. Canvas: 192×192px.
  2. Non-square icons: the long side of the icons should be 160px.
  3. Square icons: 154×154px.
  • Done

Color, stroke width and rounding

  1. Color: black #000.
  2. No fill. Base stroke width: 12px. 14px, 10px, 8px — depending on the shape of the icons. 6px — for fine details.
  3. Rounded ends and joins. 90° corners are rounded by 6-32px.
  • Done

Naming

  1. Names should match the official app name and contain no additional text.
  2. If the first 3 characters of the app name contain letters not from the English alphabet, then add a localized (or transliterated) name via ~~. Example: 京东 ~~ JD.
  3. The names of the drawables should repeat the names of the apps if nothing prevents it.
  • Done

Quality

  1. Ensure that icons are easily recognizable.
  2. Align icons to the visual center as much as possible within the guidelines. The visual center is where your icon looks and feels centered.
  3. Avoid noticable black spots by reducing the stroke width or simplifying the icons.
  4. Avoid close distances between strokes. The icons on the phone screen will be smaller, so the small distances between the strokes will stick together.
  5. Avoid drastic changes in stroke widths. When the strokes next to each other differ in width by 4px or more, the icon will look sloppy.
  • Done

@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label Aug 23, 2024
Copy link
Collaborator

@x9136 x9136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Custom Uploader icon size and opacity are not suitable.

@x9136 x9136 added the rework The team has requested changes in the issue or PR. label Aug 27, 2024
@I21b
Copy link
Contributor Author

I21b commented Aug 27, 2024

The Custom Uploader icon size and opacity are not suitable.

i forgot, change later

custom_uploader svg
@I21b I21b requested a review from x9136 August 27, 2024 17:32
@x9136 x9136 merged commit b9c4f8a into LawnchairLauncher:develop Aug 27, 2024
4 checks passed
twnesss pushed a commit to twnesss/lawnicons that referenced this pull request Oct 9, 2024
* +3 icons

* minor fix

custom_uploader svg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. rework The team has requested changes in the issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants