Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+41 added, 2 Linked, 3 Updated #2325

Closed

Conversation

Ahmed-Khalifa
Copy link
Contributor

Added

  • 150X Duplicate File Remover Pro (com.nutuvamapp.onefivexduplicatexapp/com.nutuvamapp.onefivexduplicatexapp.activity.SplashActivity)
  • 1inch: Crypto DeFi Wallet (io.oneinch.android/io.oneinch.android.presentation.ui.LaunchActivity)
  • AlDawaa Pharmacies (com.kr.aldawaa/com.kr.aldawaa.view.SplashActivity)
  • AlinmaPay E-Wallet (com.alinma.pay.consumer/com.alinma.pay.consumer.MainActivity)
  • Alromansiah Restaurants (com.tech_world.romansia/com.tech_world.romansia.ui.splash.SplashActivity)
  • Barq (sa.com.barraq/com.globalfinancingsolutions.ui.splash.SplashActivity)
  • BCare (com.app.bcare/com.nqdi.app.MainActivity)
  • BrickMania (net.countrymania.brick/net.countrymania.brick.activities.start.StartActivity)
  • Bubble Level PRO (bubble.level.ruler.pro/com.coocent.bubblelevel.ui.activity.LauncherActivity)
  • Caar Station (com.token.caarstation/com.token.caarstation.MainActivity)
  • CoinGecko: NFT, Crypto Tracker (com.coingecko.coingeckoapp/com.coingecko.coingeckoapp.MainActivity)
  • Core | Crypto Wallet and NFTs (com.avaxwallet/com.avaxwallet.MainActivity)
  • DEX Screener (com.dexscreener/com.dexscreener.MainActivity)
  • DiskUsage (com.panaustik.memmap/com.panaustik.memmap.activity.MainActivity)
  • Dr. Endoscope - USB camera Pro (net.usb.usby5/za.za.core.MainActivity)
  • Elite Hospital (ats.ksa.elite.patient/com.ats.hospital.presenter.ui.activities.SplashActivity)
  • eXtra (com.asgatech.extra/com.example.flutterapp.MainActivity)
  • FRiENDi Package (sa.friendimobile.vm/sa.virginmobile.vm.ui.splash.SplashActivity)
  • Gate.io - Buy Bitcoin and Crypto (com.gateio.gateio/com.gateio.biz.main.splash.SplashActivity)
  • GeckoTerminal - DEX Tracker (com.geckoterminal.www.twa/com.geckoterminal.www.twa.LauncherActivity)
  • Hitman Sniper (com.squareenixmontreal.hitmansniperandroid/com.prime31.UnityPlayerNativeActivity)
  • Hydra 4K (com.shadeed.ibopro/com.shadeed.ibopro.MainActivity)
  • IKTISSAB (com.othaim.Iktissab/com.othaim.Iktissab.MainActivity)
  • Jahez (net.jahez/net.jahez.core.HomeActivity)
  • Max Fashion (com.landmarkgroup.maxstores/com.landmarkgroupreactapps.SplashActivity)
  • meem KSA (com.veripark.GIB/com.veripark.GIB.meemKSA)
  • MP3 Quran (my.smartech.mp3quran/my.smartech.mp3quran.ui.SplashActivity)
  • Mrsool~~مرسول (com.mrsool/com.mrsool.SplashAc5tivity)
  • MyUS Global Shipping App (com.myus.app/com.myus.app.MainActivity)
  • Ninja~~نينجا (com.ananinja.lava/com.ananinja.MainActivity)
  • Pricena (com.naddad.pricena/com.naddad.pricena.activities.MainActivity_)
  • Saco (sa.saco.mobile/sa.saco.mobile.SplashActivity)
  • Smudgess (com.gng.smudgess/com.amaan.app.features.MainActivity)
  • Solflare - Solana Wallet (com.solflare.mobile/com.solflare.mobile.MainActivity)
  • Speero Spare Parts and Services (net.speero.android/net.speero.android.ui.MainHomeActivity)
  • Spot On Chain (network.spotonchain/network.spotonchain.MainActivity)
  • STC Bank (sa.com.stcbank/sa.com.stcbank.launcher_d2bb6544d0c7607f9e371c3f8be743ad2954f8102a2c7f7665390b1561acfb47)
  • Tikmo (com.tiqmo.wallet.ksa.prod/cn.swiftpass.wallet.tiqmo.module.login.view.SplashActivity)
  • ToYou - Delivery and Rides (com.arammeem.android.apps.toyou/com.arammeem.toyou.android.app.ui.authorization.AuthorizationActivity)
  • Uniswap: Crypto and NFT Wallet (com.uniswap.mobile/com.uniswap.MainActivity)
  • بيت الشاورما~~Shawarma House (com.shawarmahouse.www/com.shawarmahouse.www.MainActivity)

Linked

  • CoinGecko: NFT, Crypto Tracker (linked com.coingecko.coingeckoapp/com.zoontek.rnbootsplash.RNBootSplashActivity to @drawable/coingecko)
  • Hitman Sniper (linked com.squareenixmontreal.hitmansniperandroid/com.unity3d.player.UnityPlayerActivity to @drawable/sniper)

Updated

almanea ('com.almanea.android')
hungerstation ('com.hungerstation.android.web')
mada_pay ('com.mada.madapay')

Contributor's checklist

  • I followed the Lawnicons guidelines and will make changes if someone suggests. I will also make sure that Lawnicons builds correctly.

@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label Sep 12, 2024
Copy link
Contributor

Thanks for your contribution!

While waiting for a review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons.

Canvas and sizes

  1. Canvas: 192×192px.
  2. Non-square icons: the long side of the icons should be 160px.
  3. Square icons: 154×154px.
  • Approved by the Lawnicons reviewer

Color, stroke width and rounding

  1. Color: non-transparent black #000.
  2. No fill. Base stroke width: 12px. 14px, 10px, 8px — depending on the shape of the icons. 6px — for fine details.
  3. Rounded ends and joins. 90° corners are rounded by 6-32px.
  • Approved by the Lawnicons reviewer

Naming

  1. Names should match the official app name and contain no additional text.
  2. If the first 3 characters of the app name contain letters not from the English alphabet, then add a localized (or transliterated) name via ~~. Example: 京东 ~~ JD.
  3. The names of the drawables should repeat the names of the apps if nothing prevents it.
  • Approved by the Lawnicons reviewer

Quality

  1. Ensure that icons are easily recognizable.
  2. Align icons to the visual center as much as possible within the guidelines. The visual center is where your icon looks and feels centered.
  3. Avoid noticable black spots by reducing the stroke width or simplifying the icons.
  4. Avoid close distances between strokes. The icons on the phone screen will be smaller, so the small distances between the strokes will stick together.
  5. Avoid drastic changes in stroke widths. When the strokes next to each other differ in width by 4px or more, the icon will look sloppy.
  • Approved by the Lawnicons reviewer

@x9136
Copy link
Collaborator

x9136 commented Sep 12, 2024

A full-fledged review can take more than a month, because many icons do not fit in size, and even more do not fit in quality. At first glance, no more than 10 icons are suitable right now.

The second issue is the synchronization of your branch with the main one. This was not done, which led to a conflict between branches, unnecessary changes and unnecessary icon replacements.

I'm the only reviewer at the moment, but I don't have that much time to write dozens of comments either. Therefore, in order to refine all these icons to a suitable state, I suggest you:

  1. Check and refine the icons yourself. Rely on the bot's comment with the summary of the Lawnicons guidelines.
  2. Synchronize your branch with the main repository so that there are no conflicts between branches and only the icons and the appfilter.xml are updated.
  3. Create pull requests with no more than 10-12 icons. These should be icons that you are sure of, because the comments are repeated: icon size, quality, stroke width, and so on.

Or make all these icons perfect, then no one will need to comment on them and there will be time to look at 100 icons at a time.

@x9136 x9136 added the rework The team has requested changes in the issue or PR. label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. rework The team has requested changes in the issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants