Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ 5 updates, + 10 links, + 1 icon #2484

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Conversation

Hamster45105
Copy link
Contributor

@Hamster45105 Hamster45105 commented Dec 15, 2024

Description

Updated 5 icons, added 10 new links and added 1 new icon.

Icons addition information

Added

SkyCards (com.flightradar24.skycards)

Linked

Arc Search x 8 (company.thebrowser.arcarc_search.svg)
Grit (com.shub39.gritsnaptick.svg)
ntodotxt (de.tnmgl.ntodotxttasky.svg)

Updated

TgMonet Theme (com.c3r5b8.telegram_monet) - Renamed and new icon
AirNav Radar (com.airnav.radarbox) - Renamed
A101 (com.a101kapida.android) - Renamed and new icon - Closes #2476
Image Toolbox (ru.tech.imageresizershrinker) - New icon - Closes #2463
InnerTune (Fork) (com.malopieds.innertune) - New icon - Closes #2461

Copy link
Contributor

Thanks for your contribution!

We hope that you followed the Lawnicons guidelines and made sure that Lawnicons is built correctly.

Tip

While waiting for a brief and strict review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons. Additionally, you can find and install the debug build of your PR.

Lawnicons guidelines

Quality

  1. Ensure that icons are easily recognizable.
  2. Align icons to the visual center as much as possible within the guidelines. The visual center is where your icon looks and feels centered.
  3. Avoid noticable black spots by reducing the stroke width or simplifying the icons.
  4. Avoid close distances between strokes. The icons on the phone screen will be smaller, so the small distances between the strokes will stick together.
  5. Avoid drastic changes in stroke widths. When the strokes next to each other differ in width by 4px or more, the icon will look sloppy.

Canvas and sizes

  1. Canvas: 192×192px.
  2. Non-square icons: the long side of the icons should be 160px.
  3. Square icons: 154×154px.

Color, stroke width and rounding

  1. Color: non-transparent black #000.
  2. No fill. Base stroke width: 12px. 14px, 10px, 8px — depending on the shape of the icons. 6px — for fine details.
  3. Rounded ends and joins. 90° corners are rounded by 6-32px.

Naming

  1. Names should match the official app name and contain no additional text.
  2. If the first 3 characters of the app name contain letters not from the English alphabet, then add a localized (or transliterated) name via ~~. Example: 京东 ~~ JD.
  3. The names of the drawables should repeat the names of the apps if nothing prevents it.

@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label Dec 15, 2024
@Hamster45105 Hamster45105 changed the title + 5 updates, + 9 links, + 1 icon + 6 updates, + 9 links, + 1 icon Dec 15, 2024
@Hamster45105 Hamster45105 changed the title + 6 updates, + 9 links, + 1 icon + 6 updates, + 10 links, + 2 icons Dec 16, 2024
@x9136
Copy link
Collaborator

x9136 commented Dec 16, 2024

SkyCards

Align icons to the visual center as much as possible within the guidelines. The visual center is where your icon looks and feels centered.

ntodotxt

We already have a check mark, it's better to link the app to it instead of a new icon.

TgMonet Theme

The idea of the issue was to update the paper plane in the TgMonet Theme icon. Therefore, your option doesn't close the issue. But now the app has an icon without the paper plane, so the update can be accepted.

BOM Weather (au.gov.bom.metview) - Improved icon

For the sake of quality, it's worth avoiding text in icons whenever possible. In this case, this is easy because the text duplicates the app label, and the sun allows you to keep the app recognizable for users who disable labels.

Image Toolbox

Avoid noticable black spots by reducing the stroke width or simplifying the icons.

InnerTune

The icon doesn't correspond to the Lawnicons guidelines for several reasons. This option would be suitable:
review

@x9136 x9136 added the rework The team has requested changes in the issue or PR. label Dec 16, 2024
app/assets/appfilter.xml Outdated Show resolved Hide resolved
@Hamster45105 Hamster45105 changed the title + 6 updates, + 10 links, + 2 icons + 5 updates, + 10 links, + 1 icon Dec 16, 2024
@Hamster45105
Copy link
Contributor Author

The idea of the issue was to update the paper plane in the TgMonet Theme icon. Therefore, your option doesn't close the issue. But now the app has an icon without the paper plane, so the update can be accepted.

I do not see why it would not close the issue. No one will be updating the paper plane and closing the issue because the app icon doesn't have one.

@x9136
Copy link
Collaborator

x9136 commented Dec 16, 2024

I do not see why it would not close the issue.

I would prefer to close this issue through discussion rather than through the PR, as it was solved differently.

@x9136 x9136 merged commit ce46f27 into LawnchairLauncher:develop Dec 16, 2024
6 checks passed
@Hamster45105 Hamster45105 deleted the 15/12 branch December 16, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. rework The team has requested changes in the issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A101 Kapıda app icon rebranding request Image Toolbox Update Innertunne icon update
2 participants