Fbe/token account owner display #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…KI except Nano S)
fbeutin-ledger
force-pushed
the
fbe/token_account_owner_display
branch
from
b8f3a49 to
6f4fde9
Compare
fbeutin-ledger
force-pushed
the
fbe/token_account_owner_display
branch
from
754e09a to
7866cdc
Compare
Justkant
reviewed
Dec 13, 2024
| SIGNATURE = 0x15, | ||
| } e_tlv_tag; | ||
|
|
||
| typedef enum { KEY_ID_TEST = 0x00, KEY_ID_PROD = 0x03 } e_key_id; |
There was a problem hiding this comment.
KEY_ID_PROD is expected to be 0x07, I tested locally and it works with the current cal
Suggested change
| typedef enum { KEY_ID_TEST = 0x00, KEY_ID_PROD = 0x03 } e_key_id; | |
| typedef enum { KEY_ID_TEST = 0x00, KEY_ID_PROD = 0x07 } e_key_id; |
|
Close this PR as duplicate of #99 (done after cherry-picking the 3 additional commits) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.