Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute budget and split stake instruction support #90

Merged
merged 30 commits into from
Sep 11, 2024

Conversation

0xMMBD
Copy link

@0xMMBD 0xMMBD commented Jun 27, 2024

Changeset:

  • Added split-stake instruction support for:

    • SystemTransfer + SystemAllocate + SystemAssign + StakeSplit
    • SystemTransfer + SystemAllocateWithSeed + StakeSplit
  • Compute Budget instruction

    • request heap frame
    • set compute unit price
    • request units
    • set compute unit limit

0xMMBD and others added 11 commits March 29, 2024 16:57
* Added support for compute budget instructions:
* request heap frame
* set compute unit price
* request units
* set compute unit limit
* added unit tests

Co-authored-by: Piotr Swierzy <[email protected]>
* Added split-stake instruction support for:
    * SystemTransfer + SystemAllocate + SystemAssign + StakeSplit
    * SystemTransfer + SystemAllocateWithSeed + StakeSplit

Co-authored-by: Maciej Nabiałek <[email protected]>
…it and unit price (#15)

* Refactor ComputeBudget fees screen - calculate max fees from unit limit and unit price

* Fix lint error

* Fix max fees calculation - include signatures count

* Fix unit tests

* Improved logic for calculate_max_fee
@0xMMBD
Copy link
Author

0xMMBD commented Aug 30, 2024

  • Change ComputeBudget instruction to display Max fees

@0xMMBD
Copy link
Author

0xMMBD commented Sep 10, 2024

@sponomarev Unable to reproduce and fix errors with the ragger tests for stax and flex. Problem is visible even on the develop branch (LedgerHQ/app-solana repo) - looks unrelated to the changes present in this PR
Example job logs(run on commit 4d88a45): https://github.com/blockydevs/app-solana/actions/runs/10800057270/job/29957267466

Whats even more interesting is that locally everything seems ok, regenerating snapshot images did not produce any differences:

  • stax tests:
    image

  • flex tests:
    image

@0xMMBD
Copy link
Author

0xMMBD commented Sep 10, 2024

Looks like the tests are failing on this screen (but hard to say with 100% certainty)
00002
And I'm not able to reproduce it locally as it was shown here: #90 (comment)

@sponomarev
Copy link

@0xMMBD It seems that there were some SDK updates that slightly changed flex and stax UI. Using the latest dev tools I was able to reproduce the issue and update golden snapshots. You can check it in blockydevs#22

@0xMMBD
Copy link
Author

0xMMBD commented Sep 11, 2024

@sponomarev fixes for the tests are merged here already

@tdejoigny-ledger
Copy link

@0xMMBD could you please bump the app version ?

@0xMMBD
Copy link
Author

0xMMBD commented Sep 11, 2024

@tdejoigny-ledger is 1.5.2 ok for you?

@0xMMBD
Copy link
Author

0xMMBD commented Sep 11, 2024

@tdejoigny-ledger #94

@tdejoigny-ledger tdejoigny-ledger merged commit 787b919 into LedgerHQ:develop Sep 11, 2024
129 of 130 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants