Bootcamp update 2023 #4
Conversation
|
These are all the updates I made for this year's bootcamp devops edition |
| @@ -83,7 +83,8 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
|
|
|||
| steps: | |||
| + - uses: actions/checkout@v3 | |||
There was a problem hiding this comment.
Remove + uses: actions/checkout@v3 bellow includes version 4
There was a problem hiding this comment.
It is removed :) But it is hard to check differences on a diff statement. I attach a screenshot to see it more clear.
There was a problem hiding this comment.
Sorry my silly comment then.
| - runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| node-version: [14.x, 15.x, 16.x] |
There was a problem hiding this comment.
Maybe we can upgrade the Node versions to 16, 17 and 18
|
|
||
| * Update `ci.yml` | ||
|
|
||
| ```yml | ||
| ```diff |
There was a problem hiding this comment.
I don't like to use diff with yaml. Why? Because identation mess things up, instead we can use a comment. Maybe it's a good time to start a demo writing style guide.
| @@ -130,14 +129,14 @@ docker compose -f test-integration.yml up --force-recreate --exit-code-from buil | |||
|
|
|||
| If we run this, we will find that our service `build-db-relationships` is unable to find the postgres database: | |||
|
|
|||
| ``` | |||
| ```output | |||
There was a problem hiding this comment.
Nice I didn't know about output on markdown.
There was a problem hiding this comment.
I added output because lint shows a warning when a code block (```) has no language.
The list of supported languages/syntaxes: https://github.com/jincheng9/markdown_supported_languages
JTrillo
force-pushed
the
bootcamp-update-2023
branch
3 times, most recently
from
d969e75 to
f362f02
Compare
JTrillo
force-pushed
the
bootcamp-update-2023
branch
from
f362f02 to
898defe
Compare
No description provided.