-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a custom storage options param #246
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
=====================================
Coverage ? 78%
=====================================
Files ? 34
Lines ? 4870
Branches ? 0
=====================================
Hits ? 3781
Misses ? 1089
Partials ? 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @csy1204 Looks great. Could you add an example in the README ?
@tchaton Thanks for your reviews. |
Co-authored-by: thomas chaton <[email protected]>
Thanks @csy1204 for your contribution ;) Feel free to continue. |
Before submitting
What does this PR do?
Fixes #236 (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃