Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local downloader w cache #30

Merged
merged 7 commits into from
Feb 26, 2024

Conversation

mads-oestergaard
Copy link
Contributor

What does this PR do?

This PR adds a file format (local:) that users can prefix local paths with to get the files cached by lightning.

Motivation:
I would like to store data on a network drive that our on-prem compute nodes can mount and use, but I would also like to cache the chunks to not over-burden the network connection. With this PR, instead of doing this (which also works):

from lightning.data import StreamingDataset

dataset = StreamingDataset(input_dir="/data/shared-drive/some-data")

one can do

from lightning.data import StreamingDataset

dataset = StreamingDataset(input_dir="local:/data/shared-drive/some-data")

which will be the same, but with caching.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@mads-oestergaard
Copy link
Contributor Author

@tchaton there you go :-)

@tchaton
Copy link
Collaborator

tchaton commented Feb 26, 2024

mads-oestergaard

You rock @mads-oestergaard.

@Borda Borda requested a review from tchaton February 26, 2024 12:35
@tchaton tchaton merged commit 918f7ba into Lightning-AI:main Feb 26, 2024
26 checks passed
@mads-oestergaard mads-oestergaard deleted the local-downloader-w-cache branch February 27, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants