Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing interruptible argument for creating jobs #418

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

tchaton
Copy link
Collaborator

@tchaton tchaton commented Nov 21, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78%. Comparing base (c53cfbe) to head (5b38e56).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #418   +/-   ##
===================================
  Coverage    78%    78%           
===================================
  Files        34     34           
  Lines      5056   5056           
===================================
  Hits       3964   3964           
  Misses     1092   1092           
---- 🚨 Try these New Features:

@bhimrazy bhimrazy self-requested a review November 21, 2024 16:47
@tchaton tchaton merged commit 5eded67 into main Nov 21, 2024
27 of 28 checks passed
@tchaton tchaton deleted the add_missing_interruptible branch November 21, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants