Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: progress bar for merge_datasets #445

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

bhimrazy
Copy link
Collaborator

@bhimrazy bhimrazy commented Jan 9, 2025

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #433

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@bhimrazy bhimrazy self-assigned this Jan 9, 2025
@bhimrazy bhimrazy requested a review from tchaton as a code owner January 9, 2025 20:45
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79%. Comparing base (04e77c0) to head (f9910e5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #445   +/-   ##
===================================
  Coverage    79%    79%           
===================================
  Files        35     35           
  Lines      5102   5104    +2     
===================================
+ Hits       4006   4008    +2     
  Misses     1096   1096           

@tchaton tchaton merged commit 6bdafce into Lightning-AI:main Jan 9, 2025
29 checks passed
@bhimrazy bhimrazy deleted the fix/merge-datasets-progress branch January 10, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The progress bar for merge_datasets does not accurately represent the status of the job.
2 participants